Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(519)

Issue 191063002: Fix checked tests (Closed)

Created:
6 years, 9 months ago by hausner
Modified:
6 years, 9 months ago
Reviewers:
srdjan
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Visibility:
Public.

Description

Fix checked tests Follow-on change to implicit static getter elimination. Class finalizer needed to be updated accordingly so type checks are made on non-final fields as well. TBR Committed: https://code.google.com/p/dart/source/detail?r=33435

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M runtime/vm/class_finalizer.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
hausner
6 years, 9 months ago (2014-03-07 16:58:49 UTC) #1
hausner
Committed patchset #1 manually as r33435 (presubmit successful).
6 years, 9 months ago (2014-03-07 16:59:20 UTC) #2
srdjan
6 years, 9 months ago (2014-03-07 17:30:25 UTC) #3
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698