Fix for issue 11680

Fix for issue 11680
- implicitly store a full stack trace in Error objects when they are thrown.
- the shlFromInt on Mints and Bigints was trying to allocate a new OutOfMemory
  exception objects instead of using the pre-allocated exception object.
  Made the implementation of these methods native so that they can use the
  pre-allocated object.
- Ensure that it is not possible to allocate new OutOfMemory or StackOverflow
  exception objects.

R=ahe@google.com, srdjan@google.com

Committed: https://code.google.com/p/dart/source/detail?r=25492

[siva, 2013-07-25 01:22:55]

Peter could you review the test case to make sure it makes sense, Thanks.

[ahe, 2013-07-25 09:01:26]

Test LGTM with comments.

https://codereview.chromium.org/19106008/diff/18001/tests/language/error_stac...
File tests/language/error_stacktrace_test.dart (right):

https://codereview.chromium.org/19106008/diff/18001/tests/language/error_stac...
tests/language/error_stacktrace_test.dart:55: } on OutOfMemoryError catch (e) {
I'm not sure we can support this in dart2js.  It is very hard for us to
translate native exceptions from the JavaScript VM.

Also, if the JavaScript VM gives us a stack trace, I don't think we should throw
it away.

Perhaps you can move this class to its own file?

https://codereview.chromium.org/19106008/diff/18001/tests/language/error_stac...
tests/language/error_stacktrace_test.dart:116: } on NoSuchMethodError catch (e)
{
This seems a bit convoluted. You expect e.stackTrace to throw, but yet you test
the result.

[siva, 2013-07-25 17:40:25]

https://codereview.chromium.org/19106008/diff/18001/tests/language/error_stac...
File tests/language/error_stacktrace_test.dart (right):

https://codereview.chromium.org/19106008/diff/18001/tests/language/error_stac...
tests/language/error_stacktrace_test.dart:55: } on OutOfMemoryError catch (e) {
I have moved this into standalone/oom_error_stacktrace_test.dart
and will mark the status file as stating this should not be tested
on dart2js

On 2013/07/25 09:01:26, ahe wrote:
> I'm not sure we can support this in dart2js.  It is very hard for us to
> translate native exceptions from the JavaScript VM.
> 
> Also, if the JavaScript VM gives us a stack trace, I don't think we should
throw
> it away.
> 
> Perhaps you can move this class to its own file?

https://codereview.chromium.org/19106008/diff/18001/tests/language/error_stac...
tests/language/error_stacktrace_test.dart:116: } on NoSuchMethodError catch (e)
{
Changed line to just access stackTrace without the convoluted Expect statement.

On 2013/07/25 09:01:26, ahe wrote:
> This seems a bit convoluted. You expect e.stackTrace to throw, but yet you
test
> the result.

[ahe, 2013-07-25 17:45:31]

Thank you, Siva, the tests LGTM!

https://codereview.chromium.org/19106008/diff/28001/tests/standalone/standalo...
File tests/standalone/standalone.status (right):

https://codereview.chromium.org/19106008/diff/28001/tests/standalone/standalo...
tests/standalone/standalone.status:117: oom_error_stacktrace_test: Skip # (OOM
on JS may produce a stacktrace).
Could you mark it Fail, OK?

[srdjan, 2013-07-25 17:47:08]

LGTM

https://codereview.chromium.org/19106008/diff/28001/runtime/vm/exceptions.cc
File runtime/vm/exceptions.cc (right):

https://codereview.chromium.org/19106008/diff/28001/runtime/vm/exceptions.cc#...
runtime/vm/exceptions.cc:52: virtual bool full_stacktrace() const = 0;
I think virtuals are typically in CamelCase.

https://codereview.chromium.org/19106008/diff/28001/runtime/vm/exceptions.cc#...
runtime/vm/exceptions.cc:66: GrowableObjectArray::Handle()),
Indent should be another 4 spaces (here and below).

[siva, 2013-07-25 19:28:42]

https://codereview.chromium.org/19106008/diff/28001/runtime/vm/exceptions.cc
File runtime/vm/exceptions.cc (right):

https://codereview.chromium.org/19106008/diff/28001/runtime/vm/exceptions.cc#...
runtime/vm/exceptions.cc:52: virtual bool full_stacktrace() const = 0;
On 2013/07/25 17:47:08, srdjan wrote:
> I think virtuals are typically in CamelCase.

Done.

https://codereview.chromium.org/19106008/diff/28001/runtime/vm/exceptions.cc#...
runtime/vm/exceptions.cc:66: GrowableObjectArray::Handle()),
On 2013/07/25 17:47:08, srdjan wrote:
> Indent should be another 4 spaces (here and below).

Done.

https://codereview.chromium.org/19106008/diff/28001/tests/standalone/standalo...
File tests/standalone/standalone.status (right):

https://codereview.chromium.org/19106008/diff/28001/tests/standalone/standalo...
tests/standalone/standalone.status:117: oom_error_stacktrace_test: Skip # (OOM
on JS may produce a stacktrace).
On 2013/07/25 17:45:31, ahe wrote:
> Could you mark it Fail, OK?
> 

Done.

[siva, 2013-07-25 19:29:04]

Committed patchset #5 manually as r25492 (presubmit successful).