Fix issue 11705: deal with user-defined Function classes that override noSuchMethod, and are being …

Fix issue 11705: deal with user-defined Function classes that override noSuchMethod, and are being called with apply.

R=ahe@google.com

Committed: https://code.google.com/p/dart/source/detail?r=24950

[ahe, 2013-07-12 14:56:41]

LGTM

https://codereview.chromium.org/19101002/diff/1/sdk/lib/_internal/lib/js_help...
File sdk/lib/_internal/lib/js_helper.dart (right):

https://codereview.chromium.org/19101002/diff/1/sdk/lib/_internal/lib/js_help...
sdk/lib/_internal/lib/js_helper.dart:594: return function.noSuchMethod(new
JSInvocationMirror(
Please use createUnmangledInvocationMirror.

https://codereview.chromium.org/19101002/diff/1/sdk/lib/_internal/lib/js_help...
sdk/lib/_internal/lib/js_helper.dart:595: 'call',
I think this should be const Symbol('call'). Did you test this in minified mode?

[ngeoffray, 2013-07-12 15:16:17]

Thanks Peter.

https://codereview.chromium.org/19101002/diff/1/sdk/lib/_internal/lib/js_help...
File sdk/lib/_internal/lib/js_helper.dart (right):

https://codereview.chromium.org/19101002/diff/1/sdk/lib/_internal/lib/js_help...
sdk/lib/_internal/lib/js_helper.dart:594: return function.noSuchMethod(new
JSInvocationMirror(
On 2013/07/12 14:56:41, ahe wrote:
> Please use createUnmangledInvocationMirror.

Done.

https://codereview.chromium.org/19101002/diff/1/sdk/lib/_internal/lib/js_help...
sdk/lib/_internal/lib/js_helper.dart:595: 'call',
On 2013/07/12 14:56:41, ahe wrote:
> I think this should be const Symbol('call'). Did you test this in minified
mode?

It passes in minified mode. As discussed, I'll change it to use const
Symbol('call') to play it safe.

[ngeoffray, 2013-07-12 15:16:57]

Committed patchset #2 manually as r24950 (presubmit successful).