Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Issue 19090002: Update dart:chrome APIs and include chrome.fileSystem (Closed)

Created:
7 years, 5 months ago by benwells
Modified:
7 years, 5 months ago
Reviewers:
blois
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Update dart:chrome APIs and include chrome.fileSystem chrome.fileSystem is needed to do integration testing. BUG=None R=blois@google.com Committed: https://code.google.com/p/dart/source/detail?r=24988

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+318 lines, -194 lines) Patch
M tools/dom/scripts/chromegenerator.py View 1 chunk +1 line, -0 lines 0 comments Download
M tools/dom/src/chrome/app_runtime.dart View 9 chunks +9 lines, -111 lines 0 comments Download
M tools/dom/src/chrome/app_window.dart View 13 chunks +111 lines, -79 lines 0 comments Download
A tools/dom/src/chrome/file_system.dart View 1 chunk +193 lines, -0 lines 0 comments Download
M tools/dom/templates/html/dart2js/chrome_dart2js.darttemplate View 3 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
benwells
Integration test to follow ...
7 years, 5 months ago (2013-07-12 07:29:31 UTC) #1
blois
lgtm
7 years, 5 months ago (2013-07-12 23:28:17 UTC) #2
benwells
7 years, 5 months ago (2013-07-15 01:11:30 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r24988 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698