Issue 190753004: - Ensure that all names in local scopes are symbols.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 190753004: - Ensure that all names in local scopes are symbols. (Closed)

Created:
6 years, 9 months ago by Ivan Posva

Modified:
6 years, 9 months ago

Reviewers:
srdjan, hausner

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

- Ensure that all names in local scopes are symbols. - Avoid calling Equals when comparing names in local scopes. R=srdjan@google.com Committed: https://code.google.com/p/dart/source/detail?r=33443

Created: 6 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+67 lines, -62 lines)			Patch
M	runtime/vm/ast_printer_test.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	runtime/vm/ast_test.cc	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	runtime/vm/compiler_stats.h	View	1 chunk	+17 lines, -17 lines	0 comments	Download
M	runtime/vm/compiler_stats.cc	View	3 chunks	+36 lines, -36 lines	0 comments	Download
M	runtime/vm/flow_graph_builder.cc	View	1 chunk	+1 line, -2 lines	0 comments	Download
M	runtime/vm/scopes.h	View	3 chunks	+3 lines, -0 lines	0 comments	Download
M	runtime/vm/scopes.cc	View	4 chunks	+6 lines, -4 lines	0 comments	Download
M	runtime/vm/symbols.h	View	1 chunk	+1 line, -0 lines	0 comments	Download

Total messages: 3 (0 generated)

Ivan Posva

6 years, 9 months ago (2014-03-07 19:37:15 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r33443 (presubmit successful).