Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(461)

Issue 190723008: Fix type error in implementation of dart:io Directory.existsSync. (Closed)

Created:
6 years, 9 months ago by Bill Hesse
Modified:
6 years, 9 months ago
Reviewers:
Søren Gjesse
CC:
reviews_dartlang.org, ricow1, vm-dev_dartlang.org
Visibility:
Public.

Description

Fix type error in implementation of dart:io Directory.existsSync. Add checked-in binary for mips architecture to tools/testing. BUG= R=sgjesse@google.com Committed: https://code.google.com/p/dart/source/detail?r=33483

Patch Set 1 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M runtime/bin/directory_patch.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/_internal/lib/io_patch.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/io/directory_impl.dart View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
Bill Hesse
6 years, 9 months ago (2014-03-10 11:57:04 UTC) #1
Søren Gjesse
lgtm
6 years, 9 months ago (2014-03-10 11:59:20 UTC) #2
Bill Hesse
6 years, 9 months ago (2014-03-10 12:00:43 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r33483 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698