Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(383)

Issue 19072003: Get rid of command-line config in pub. (Closed)

Created:
7 years, 5 months ago by Bob Nystrom
Modified:
7 years, 5 months ago
CC:
reviews_dartlang.org, Siggi Cherem (dart-lang)
Visibility:
Public.

Description

Get rid of command-line config in pub. unittest's compact config is close enough and better maintained. R=nweiz@google.com Committed: https://code.google.com/p/dart/source/detail?r=24937

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -165 lines) Patch
D sdk/lib/_internal/pub/test/command_line_config.dart View 1 chunk +0 lines, -160 lines 0 comments Download
M sdk/lib/_internal/pub/test/test_pub.dart View 2 chunks +2 lines, -5 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Bob Nystrom
Compact VM config FTW!
7 years, 5 months ago (2013-07-11 23:14:13 UTC) #1
Siggi Cherem (dart-lang)
STV! once Nathan's can add stack_trace back to unittest we will be golden! =)
7 years, 5 months ago (2013-07-11 23:18:15 UTC) #2
nweiz
lgtm
7 years, 5 months ago (2013-07-11 23:29:48 UTC) #3
Bob Nystrom
7 years, 5 months ago (2013-07-12 00:31:35 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 manually as r24937 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698