Issue 1907023002: Respond to feedback in https://codereview.chromium.org/1902993003/.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1907023002: Respond to feedback in https://codereview.chromium.org/1902993003/. (Closed)

Created:
4 years, 8 months ago by Bob Nystrom

Modified:
4 years, 8 months ago

Reviewers:
nweiz

CC:
reviews_dartlang.org

Base URL:
https://github.com/dart-lang/pub.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

Created: 4 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -3 lines)			Patch
	M	lib/src/utils.dart	View		2 chunks	+1 line, -2 lines	0 comments	Download
	M	pubspec.yaml	View		1 chunk	+0 lines, -1 line	0 comments	Download

Total messages: 5 (2 generated)

Bob Nystrom

4 years, 8 months ago (2016-04-21 22:29:33 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
3a79b4131d6a277cf3be4c2b193cb173d08e4f4f (presubmit successful).