Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Issue 1907013002: Expand the version constraint to allow using csslib 0.13.x. (Closed)

Created:
4 years, 8 months ago by Bob Nystrom
Modified:
4 years, 8 months ago
Reviewers:
Jennifer Messerly
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/html.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Expand the version constraint to allow using csslib 0.13.x. I've pushed out new versions of csslib that are strong mode clean. They technically have some breaking changes, so I bumped the version past 0.12.0, but in practice html works with them just fine. This allows that. R=jmesserly@google.com Committed: https://github.com/dart-lang/html/commit/911692991bb02f6f102e4158b2984d24dee6ebd5

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -2 lines) Patch
M CHANGELOG.md View 1 chunk +3 lines, -0 lines 0 comments Download
M pubspec.yaml View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Bob Nystrom
Assuming this is OK, I'd also like to publish this. Can you give add me ...
4 years, 8 months ago (2016-04-21 20:32:39 UTC) #2
Jennifer Messerly
lgtm
4 years, 8 months ago (2016-04-21 20:45:28 UTC) #3
Bob Nystrom
4 years, 8 months ago (2016-04-21 20:46:18 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
911692991bb02f6f102e4158b2984d24dee6ebd5 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698