Issue 1906093002: Close underlying Hash sinks.

Issue 1906093002: Close underlying Hash sinks. (Closed)

Created:
4 years, 8 months ago by nweiz

Modified:
4 years, 8 months ago

Reviewers:
kevmoo

CC:
reviews_dartlang.org

Base URL:
git@github.com:dart-lang/crypto@master

Target Ref:
refs/heads/master

Visibility:
Public.

Created: 4 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+36 lines, -1 line)			Patch
M	CHANGELOG.md	View		1 chunk	+5 lines, -0 lines	0 comments	Download
M	lib/src/hash_sink.dart	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	pubspec.yaml	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	test/sha1_test.dart	View		2 chunks	+13 lines, -0 lines	0 comments	Download
M	test/sha256_test.dart	View		2 chunks	+16 lines, -0 lines	0 comments	Download

Total messages: 6 (2 generated)

kevmoo

LGTM, but... 1) version change? 2) We now have 2 packages out that work-around this ...

4 years, 8 months ago (2016-04-21 20:34:04 UTC) #3

nweiz

On 2016/04/21 20:34:04, kevmoo wrote: > 1) version change? Done. > 2) We now have ...

4 years, 8 months ago (2016-04-21 20:40:16 UTC) #4

nweiz

4 years, 8 months ago (2016-04-21 20:40:44 UTC) #6

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as
d257280c25a7cbce5032e779df2dc20d2530addd (presubmit successful).