Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(191)

Issue 190553002: Tests that inheritance of deferred classes is disallowed (Closed)

Created:
6 years, 9 months ago by sigurdm
Modified:
6 years, 5 months ago
Reviewers:
floitsch
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Tests that inheritance of deferred classes is disallowed The implementation of this constraint is implied for dart2js by Issue 177543002 (Constrain type annotations with deferred types.) R=floitsch@google.com Committed: https://code.google.com/p/dart/source/detail?r=38022

Patch Set 1 #

Patch Set 2 : Add test for redirecting constructor. Remove status-changes. Use new syntax #

Total comments: 2

Patch Set 3 : Make multi-tests more specific #

Patch Set 4 : Remove trailing whitespace #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -3 lines) Patch
A + tests/language/deferred_inheritance_constraints_lib.dart View 1 2 1 chunk +2 lines, -3 lines 0 comments Download
A tests/language/deferred_inheritance_constraints_test.dart View 1 2 1 chunk +34 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
sigurdm
6 years, 9 months ago (2014-03-07 10:26:08 UTC) #1
floitsch
LGTM.
6 years, 9 months ago (2014-03-07 13:46:42 UTC) #2
sigurdm
This Cl has been hiding for some time. PTAL
6 years, 5 months ago (2014-07-04 11:22:19 UTC) #3
floitsch
LGTM. https://codereview.chromium.org/190553002/diff/20001/tests/language/deferred_inheritance_constraints_test.dart File tests/language/deferred_inheritance_constraints_test.dart (right): https://codereview.chromium.org/190553002/diff/20001/tests/language/deferred_inheritance_constraints_test.dart#newcode8 tests/language/deferred_inheritance_constraints_test.dart:8: class C extends lib.E {} /// extends: compile-time ...
6 years, 5 months ago (2014-07-04 11:28:39 UTC) #4
sigurdm
https://codereview.chromium.org/190553002/diff/20001/tests/language/deferred_inheritance_constraints_test.dart File tests/language/deferred_inheritance_constraints_test.dart (right): https://codereview.chromium.org/190553002/diff/20001/tests/language/deferred_inheritance_constraints_test.dart#newcode8 tests/language/deferred_inheritance_constraints_test.dart:8: class C extends lib.E {} /// extends: compile-time error ...
6 years, 5 months ago (2014-07-07 08:12:21 UTC) #5
floitsch
Still LGTM.
6 years, 5 months ago (2014-07-07 08:53:43 UTC) #6
sigurdm
6 years, 5 months ago (2014-07-07 09:37:12 UTC) #7
Message was sent while issue was closed.
Committed patchset #4 manually as r38022 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698