Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(898)

Issue 190543005: bump pubspecs for pkgs that depend on analyzer (Closed)

Created:
6 years, 9 months ago by Jennifer Messerly
Modified:
6 years, 9 months ago
Reviewers:
dgrove, kevmoo
CC:
reviews_dartlang.org, Alan Knight
Visibility:
Public.

Description

bump pubspecs for pkgs that depend on analyzer analyzer-dev.5 had a bug fix for polymer; this bumps the dep so I can upload a fixed version. R=dgrove@google.com Committed: https://code.google.com/p/dart/source/detail?r=33509

Patch Set 1 #

Total comments: 1

Patch Set 2 : revert intl #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M pkg/observe/pubspec.yaml View 1 1 chunk +1 line, -1 line 0 comments Download
M pkg/polymer/pubspec.yaml View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
Jennifer Messerly
This lets me upload a version of polymer that interacts correctly with analyzer. Otherwise I ...
6 years, 9 months ago (2014-03-07 23:38:49 UTC) #1
Jennifer Messerly
On 2014/03/07 23:38:49, John Messerly wrote: > This lets me upload a version of polymer ...
6 years, 9 months ago (2014-03-07 23:39:39 UTC) #2
dgrove
lgtm
6 years, 9 months ago (2014-03-08 01:00:37 UTC) #3
kevmoo
https://codereview.chromium.org/190543005/diff/1/pkg/intl/pubspec.yaml File pkg/intl/pubspec.yaml (right): https://codereview.chromium.org/190543005/diff/1/pkg/intl/pubspec.yaml#newcode2 pkg/intl/pubspec.yaml:2: version: 0.9.8 A non-dev version with -dev dependencies? Weird, ...
6 years, 9 months ago (2014-03-08 20:10:08 UTC) #4
Jennifer Messerly
On 2014/03/08 20:10:08, kevmoo wrote: > https://codereview.chromium.org/190543005/diff/1/pkg/intl/pubspec.yaml > File pkg/intl/pubspec.yaml (right): > > https://codereview.chromium.org/190543005/diff/1/pkg/intl/pubspec.yaml#newcode2 > ...
6 years, 9 months ago (2014-03-10 23:18:38 UTC) #5
Jennifer Messerly
6 years, 9 months ago (2014-03-10 23:21:24 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 manually as r33509 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698