Issue 19034002: Add VMOptions to optimize tests that need to be (Part I).

Issue 19034002: Add VMOptions to optimize tests that need to be (Part I). (Closed)

Created:
7 years, 5 months ago by srdjan

Modified:
7 years, 5 months ago

Reviewers:
siva

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Add VMOptions to optimize tests that need to be (Part I). R=asiva@google.com Committed: https://code.google.com/p/dart/source/detail?r=24923

Patch Set 2 : #

Created: 7 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+45 lines, -31 lines)			Patch
M	tests/language/allocation_sinking_vm_test.dart	View	1	4 chunks	+4 lines, -3 lines	0 comments	Download
M	tests/language/arithmetic_canonicalization_test.dart	View	1	1 chunk	+2 lines, -1 line	0 comments	Download
M	tests/language/arithmetic_test.dart	View	1	2 chunks	+3 lines, -2 lines	0 comments	Download
M	tests/language/assign_op_test.dart	View	1	2 chunks	+2 lines, -1 line	0 comments	Download
M	tests/language/bit_operations_test.dart	View	1	3 chunks	+3 lines, -2 lines	0 comments	Download
M	tests/language/branch_canonicalization_test.dart	View	1	2 chunks	+2 lines, -1 line	0 comments	Download
M	tests/language/compound_assignment_operator_test.dart	View	1	2 chunks	+2 lines, -2 lines	0 comments	Download
M	tests/language/const_test.dart	View	1	3 chunks	+3 lines, -2 lines	0 comments	Download
M	tests/language/constant_propagation_phis_test.dart	View	1	3 chunks	+3 lines, -2 lines	0 comments	Download
M	tests/language/deopt_hoisted_smi_check_vm_test.dart	View	1	2 chunks	+3 lines, -2 lines	0 comments	Download
M	tests/language/deopt_inlined_function_lazy_test.dart	View	1	2 chunks	+2 lines, -2 lines	0 comments	Download
M	tests/language/deopt_no_feedback_test.dart	View	1	4 chunks	+4 lines, -3 lines	0 comments	Download
M	tests/language/deopt_smi_op_test.dart	View	1	2 chunks	+3 lines, -2 lines	0 comments	Download
M	tests/language/deoptimized_function_on_stack_test.dart	View	1	2 chunks	+3 lines, -2 lines	0 comments	Download
M	tests/language/div_with_power_of_two_test.dart	View	1	2 chunks	+2 lines, -1 line	0 comments	Download
M	tests/language/double_int_addition_test.dart	View	1	2 chunks	+4 lines, -3 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

siva

LGTM with comment about the iteration count not being sufficient to trigger optimization for some ...

7 years, 5 months ago (2013-07-11 00:14:42 UTC) #2

srdjan

https://codereview.chromium.org/19034002/diff/1/tests/language/compound_assignment_operator_test.dart File tests/language/compound_assignment_operator_test.dart (right): https://codereview.chromium.org/19034002/diff/1/tests/language/compound_assignment_operator_test.dart#newcode80 tests/language/compound_assignment_operator_test.dart:80: for (int i = 0; i < 10; i++) ...

7 years, 5 months ago (2013-07-11 17:41:01 UTC) #3

srdjan

7 years, 5 months ago (2013-07-11 17:47:48 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 manually as r24923 (presubmit successful).

Expand Messages | Collapse Messages