Issue 19023005: Implement forwarding constructors for mixins

Issue 19023005: Implement forwarding constructors for mixins (Closed)

Created:
7 years, 5 months ago by hausner

Modified:
7 years, 5 months ago

Reviewers:
srdjan

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Implement forwarding constructors for mixins By popular demand, fixes issue dartbug.com/9339 R=srdjan@google.com Committed: https://code.google.com/p/dart/source/detail?r=24977

Patch Set 2 : #

Total comments: 4

Created: 7 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+230 lines, -118 lines)			Patch
M	runtime/vm/class_finalizer.h	View		1 chunk	+3 lines, -0 lines	2 comments	Download
M	runtime/vm/class_finalizer.cc	View	1	2 chunks	+58 lines, -7 lines	2 comments	Download
M	runtime/vm/flow_graph_builder.h	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	runtime/vm/intermediate_language.h	View		2 chunks	+55 lines, -55 lines	0 comments	Download
M	runtime/vm/intrinsifier.h	View		3 chunks	+41 lines, -36 lines	0 comments	Download
M	runtime/vm/object.h	View		2 chunks	+1 line, -1 line	0 comments	Download
M	runtime/vm/object.cc	View	1	1 chunk	+1 line, -2 lines	0 comments	Download
M	runtime/vm/parser.h	View		1 chunk	+2 lines, -1 line	0 comments	Download
M	runtime/vm/parser.cc	View	1	11 chunks	+67 lines, -10 lines	0 comments	Download
M	tests/language/language.status	View	1	1 chunk	+0 lines, -4 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

srdjan

LGTM https://codereview.chromium.org/19023005/diff/9001/runtime/vm/class_finalizer.cc File runtime/vm/class_finalizer.cc (right): https://codereview.chromium.org/19023005/diff/9001/runtime/vm/class_finalizer.cc#newcode1396 runtime/vm/class_finalizer.cc:1396: const GrowableObjectArray& cloned_funcs) { ditto https://codereview.chromium.org/19023005/diff/9001/runtime/vm/class_finalizer.h File runtime/vm/class_finalizer.h ...

7 years, 5 months ago (2013-07-12 21:53:57 UTC) #2

hausner

Thank you! https://codereview.chromium.org/19023005/diff/9001/runtime/vm/class_finalizer.cc File runtime/vm/class_finalizer.cc (right): https://codereview.chromium.org/19023005/diff/9001/runtime/vm/class_finalizer.cc#newcode1396 runtime/vm/class_finalizer.cc:1396: const GrowableObjectArray& cloned_funcs) { On 2013/07/12 21:53:57, ...

7 years, 5 months ago (2013-07-12 22:00:42 UTC) #3

hausner

7 years, 5 months ago (2013-07-12 22:09:25 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 manually as r24977 (presubmit successful).

Expand Messages | Collapse Messages