Issue 19021002: Fix closure creation from function.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 19021002: Fix closure creation from function. (Closed)

Created:
7 years, 5 months ago by Michael Lippautz (Google)

Modified:
7 years, 5 months ago

Reviewers:
hausner

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Fix closure creation from function. A closure created from a function should also inherit its token end position and result type. R=hausner@google.com Committed: https://code.google.com/p/dart/source/detail?r=24895

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Created: 7 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -0 lines)			Patch
	M	runtime/vm/object.cc	View	1	1 chunk	+3 lines, -0 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

hausner

https://codereview.chromium.org/19021002/diff/1/runtime/vm/object.cc File runtime/vm/object.cc (right): https://codereview.chromium.org/19021002/diff/1/runtime/vm/object.cc#newcode4520 runtime/vm/object.cc:4520: result.set_end_token_pos(parent.end_token_pos()); As discussed offline, you need to make your ...

7 years, 5 months ago (2013-07-10 21:55:49 UTC) #2

Michael Lippautz (Google)

7 years, 5 months ago (2013-07-10 22:33:10 UTC) #3

Michael Lippautz (Google)

7 years, 5 months ago (2013-07-10 23:08:44 UTC) #5

Message was sent while issue was closed.

Committed patchset #2 manually as r24895 (presubmit successful).

Expand Messages | Collapse Messages