Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(120)

Issue 19000006: First version of Codecs and Converters. (Closed)

Created:
7 years, 5 months ago by floitsch
Modified:
7 years, 5 months ago
CC:
reviews_dartlang.org, srdjan, siva
Visibility:
Public.

Description

First version of Codecs and Converters. No chunked conversions, yet. R=asiva@google.com, lrn@google.com Committed: https://code.google.com/p/dart/source/detail?r=24999

Patch Set 1 #

Patch Set 2 : Mostly comments. #

Patch Set 3 : Revert sdk/lib/json change. #

Total comments: 62

Patch Set 4 : Address comments. #

Patch Set 5 : Fix test. #

Total comments: 2

Patch Set 6 : Address comment. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+580 lines, -15 lines) Patch
M runtime/vm/bootstrap.h View 1 chunk +2 lines, -0 lines 0 comments Download
M runtime/vm/bootstrap.cc View 1 chunk +8 lines, -0 lines 0 comments Download
M runtime/vm/object_store.h View 5 chunks +12 lines, -0 lines 0 comments Download
M runtime/vm/symbols.h View 1 chunk +2 lines, -0 lines 0 comments Download
M runtime/vm/vm.gypi View 5 chunks +86 lines, -0 lines 0 comments Download
M sdk/lib/_internal/libraries.dart View 1 chunk +6 lines, -0 lines 0 comments Download
A sdk/lib/codec/codec.dart View 1 2 3 1 chunk +107 lines, -0 lines 0 comments Download
A + sdk/lib/codec/codec_sources.gypi View 1 chunk +5 lines, -3 lines 0 comments Download
A sdk/lib/codec/encoding.dart View 1 2 3 1 chunk +30 lines, -0 lines 0 comments Download
A sdk/lib/codec/json.dart View 1 2 3 4 5 1 chunk +51 lines, -0 lines 0 comments Download
A + sdk/lib/convert/convert.dart View 1 chunk +6 lines, -5 lines 0 comments Download
A + sdk/lib/convert/convert_sources.gypi View 1 chunk +6 lines, -7 lines 0 comments Download
A sdk/lib/convert/converter.dart View 1 2 3 1 chunk +42 lines, -0 lines 0 comments Download
A sdk/lib/convert/json.dart View 1 2 3 1 chunk +74 lines, -0 lines 0 comments Download
A sdk/lib/convert/utf.dart View 1 2 3 1 chunk +31 lines, -0 lines 0 comments Download
A tests/lib/codec/codec1_test.dart View 1 chunk +70 lines, -0 lines 0 comments Download
A tests/lib/codec/codec2_test.dart View 1 2 3 4 1 chunk +42 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
floitsch
7 years, 5 months ago (2013-07-11 16:36:16 UTC) #1
Lasse Reichstein Nielsen
lgtm https://codereview.chromium.org/19000006/diff/4001/sdk/lib/codec/codec.dart File sdk/lib/codec/codec.dart (right): https://codereview.chromium.org/19000006/diff/4001/sdk/lib/codec/codec.dart#newcode19 sdk/lib/codec/codec.dart:19: * Fused codecs generally work in an optimized ...
7 years, 5 months ago (2013-07-12 11:50:46 UTC) #2
srdjan
7 years, 5 months ago (2013-07-12 15:58:05 UTC) #3
srdjan
https://codereview.chromium.org/19000006/diff/14001/sdk/lib/codec/json.dart File sdk/lib/codec/json.dart (right): https://codereview.chromium.org/19000006/diff/14001/sdk/lib/codec/json.dart#newcode46 sdk/lib/codec/json.dart:46: reviver = (reviver == null) ? _reviver : reviver; ...
7 years, 5 months ago (2013-07-12 16:03:16 UTC) #4
floitsch
https://codereview.chromium.org/19000006/diff/4001/sdk/lib/codec/codec.dart File sdk/lib/codec/codec.dart (right): https://codereview.chromium.org/19000006/diff/4001/sdk/lib/codec/codec.dart#newcode19 sdk/lib/codec/codec.dart:19: * Fused codecs generally work in an optimized way ...
7 years, 5 months ago (2013-07-12 16:09:15 UTC) #5
siva
the VM C++ parts LGTM, I haven't reviewed the dart files but I did notice ...
7 years, 5 months ago (2013-07-12 17:19:45 UTC) #6
siva
I meant "who requested these libraries"
7 years, 5 months ago (2013-07-12 17:20:22 UTC) #7
floitsch
On 2013/07/12 17:19:45, siva wrote: > the VM C++ parts LGTM, I haven't reviewed the ...
7 years, 5 months ago (2013-07-15 10:25:19 UTC) #8
floitsch
Committed patchset #6 manually as r24999 (presubmit successful).
7 years, 5 months ago (2013-07-15 10:26:51 UTC) #9
Ivan Posva
You need to find a name for dart:codec that does not imply video or audio ...
7 years, 5 months ago (2013-07-16 00:02:35 UTC) #10
dgrove
7 years, 5 months ago (2013-07-16 00:03:26 UTC) #11
Message was sent while issue was closed.
+1 to Ivan's point. I find this library name to be neither intuitive nor
discoverable.
On 2013/07/16 00:02:35, Ivan Posva wrote:
> You need to find a name for dart:codec that does not imply video or audio
> compression.
> 
> -Ivan

Powered by Google App Engine
This is Rietveld 408576698