Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(269)

Issue 189913004: Change to dart command line analyzer- Remove the rich toString in AnalyzerError to prevent .content… (Closed)

Created:
6 years, 9 months ago by jwren
Modified:
6 years, 9 months ago
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Change to dart command line analyzer- Remove the rich toString in AnalyzerError to prevent .contents from being called on a source. R=brianwilkerson@google.com, scheglov@google.com Committed: https://code.google.com/p/dart/source/detail?r=33452

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+44 lines, -39 lines) Patch
M pkg/analyzer/lib/src/error.dart View 1 chunk +44 lines, -39 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
jwren
6 years, 9 months ago (2014-03-07 20:00:54 UTC) #1
scheglov
lgtm
6 years, 9 months ago (2014-03-07 20:05:01 UTC) #2
Brian Wilkerson
LGTM
6 years, 9 months ago (2014-03-07 20:34:20 UTC) #3
jwren
6 years, 9 months ago (2014-03-07 20:55:34 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 manually as r33452 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698