Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(37)

Issue 189843003: Reapply "Access to imports in the VM's runtime mirrors. Extend test coverage of the source mirrors." (Closed)

Created:
6 years, 9 months ago by rmacnak
Modified:
6 years, 9 months ago
Reviewers:
gbracha, hausner
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Visibility:
Public.

Description

Reapply "Access to imports in the VM's runtime mirrors. Extend test coverage of the source mirrors." Regenerate snapshot test due to change in the size of Namespace. Relate the types source mirror libraries dependencies to the runtime library dependencies. BUG=http://dartbug.com/10360 Committed: https://code.google.com/p/dart/source/detail?r=33441

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+634 lines, -99 lines) Patch
M runtime/lib/mirrors.cc View 1 chunk +105 lines, -0 lines 0 comments Download
M runtime/lib/mirrors_impl.dart View 2 chunks +42 lines, -0 lines 0 comments Download
M runtime/vm/bootstrap_natives.h View 1 chunk +1 line, -0 lines 0 comments Download
M runtime/vm/object.h View 4 chunks +8 lines, -2 lines 0 comments Download
M runtime/vm/object.cc View 1 chunk +39 lines, -0 lines 0 comments Download
M runtime/vm/parser.h View 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/parser.cc View 3 chunks +9 lines, -4 lines 0 comments Download
M runtime/vm/raw_object.h View 1 chunk +3 lines, -1 line 0 comments Download
M runtime/vm/symbols.h View 1 chunk +2 lines, -0 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/mirrors/dart2js_library_mirror.dart View 5 chunks +6 lines, -6 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/mirrors/source_mirrors.dart View 3 chunks +6 lines, -4 lines 0 comments Download
M sdk/lib/_internal/lib/js_mirrors.dart View 1 chunk +3 lines, -0 lines 0 comments Download
M sdk/lib/mirrors/mirrors.dart View 1 chunk +45 lines, -0 lines 0 comments Download
M tests/compiler/dart2js/dart2js.status View 1 chunk +7 lines, -0 lines 0 comments Download
A + tests/compiler/dart2js/mirrors/library_exports_hidden_test.dart View 2 chunks +3 lines, -3 lines 0 comments Download
A + tests/compiler/dart2js/mirrors/library_exports_shown_test.dart View 2 chunks +3 lines, -3 lines 0 comments Download
A + tests/compiler/dart2js/mirrors/library_imports_hidden_test.dart View 2 chunks +3 lines, -3 lines 0 comments Download
A + tests/compiler/dart2js/mirrors/library_imports_prefixed_show_hide_test.dart View 2 chunks +3 lines, -3 lines 0 comments Download
A + tests/compiler/dart2js/mirrors/library_imports_prefixed_test.dart View 2 chunks +3 lines, -3 lines 0 comments Download
A + tests/compiler/dart2js/mirrors/library_imports_shown_test.dart View 2 chunks +3 lines, -3 lines 0 comments Download
M tests/lib/lib.status View 1 chunk +8 lines, -0 lines 0 comments Download
A + tests/lib/mirrors/library_exports_hidden.dart View 1 chunk +4 lines, -4 lines 0 comments Download
A tests/lib/mirrors/library_exports_hidden_test.dart View 1 chunk +34 lines, -0 lines 0 comments Download
A + tests/lib/mirrors/library_exports_shown.dart View 1 chunk +4 lines, -4 lines 0 comments Download
A tests/lib/mirrors/library_exports_shown_test.dart View 1 chunk +35 lines, -0 lines 0 comments Download
A + tests/lib/mirrors/library_imports_a.dart View 1 chunk +3 lines, -4 lines 0 comments Download
A + tests/lib/mirrors/library_imports_b.dart View 1 chunk +3 lines, -4 lines 0 comments Download
A + tests/lib/mirrors/library_imports_bad_metadata_test.dart View 1 chunk +8 lines, -12 lines 0 comments Download
A + tests/lib/mirrors/library_imports_hidden.dart View 1 chunk +4 lines, -4 lines 0 comments Download
A tests/lib/mirrors/library_imports_hidden_test.dart View 1 chunk +34 lines, -0 lines 0 comments Download
A + tests/lib/mirrors/library_imports_metadata.dart View 1 chunk +9 lines, -8 lines 0 comments Download
A tests/lib/mirrors/library_imports_metadata_test.dart View 1 chunk +50 lines, -0 lines 0 comments Download
A + tests/lib/mirrors/library_imports_prefixed.dart View 1 chunk +4 lines, -4 lines 0 comments Download
A + tests/lib/mirrors/library_imports_prefixed_show_hide.dart View 1 chunk +4 lines, -15 lines 0 comments Download
A tests/lib/mirrors/library_imports_prefixed_show_hide_test.dart View 1 chunk +33 lines, -0 lines 0 comments Download
A tests/lib/mirrors/library_imports_prefixed_test.dart View 1 chunk +31 lines, -0 lines 0 comments Download
A + tests/lib/mirrors/library_imports_shown.dart View 1 chunk +4 lines, -4 lines 0 comments Download
A tests/lib/mirrors/library_imports_shown_test.dart View 1 chunk +34 lines, -0 lines 0 comments Download
M tests/lib/mirrors/stringify.dart View 1 chunk +33 lines, -0 lines 0 comments Download
M tests/standalone/issue14236_test.dart View Binary file 0 comments Download

Messages

Total messages: 3 (0 generated)
rmacnak
6 years, 9 months ago (2014-03-07 03:00:15 UTC) #1
hausner
NLB (never looked better).
6 years, 9 months ago (2014-03-07 17:04:32 UTC) #2
rmacnak
6 years, 9 months ago (2014-03-07 19:00:37 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r33441 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698