Issue 189823004: Fix error where we are looking the gsutil script in the wrong location.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 189823004: Fix error where we are looking the gsutil script in the wrong location. (Closed)

Created:
6 years, 9 months ago by ricow1

Modified:
6 years, 9 months ago

Reviewers:
Bill Hesse

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Fix error where we are looking the gsutil script in the wrong location. With this change we will look in the specific dart repo location first and then afterwards search path. Additionally, give an error if we require the dart repo version but can't find it. R=whesse@google.com Committed: https://code.google.com/p/dart/source/detail?r=33423

Patch Set 1 #

Total comments: 2

Created: 6 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+15 lines, -8 lines)			Patch
	M	tools/bots/bot_utils.py	View		1 chunk	+15 lines, -8 lines	2 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Bill Hesse

lgtm https://codereview.chromium.org/189823004/diff/1/tools/bots/bot_utils.py File tools/bots/bot_utils.py (right): https://codereview.chromium.org/189823004/diff/1/tools/bots/bot_utils.py#newcode227 tools/bots/bot_utils.py:227: raise Exception("Requiring to use dart repo version of ...

6 years, 9 months ago (2014-03-07 12:19:52 UTC) #2

ricow1

Committed patchset #1 manually as r33423 (presubmit successful).

6 years, 9 months ago (2014-03-07 12:25:03 UTC) #3

ricow1

6 years, 9 months ago (2014-03-07 12:30:14 UTC) #4

Message was sent while issue was closed.

https://codereview.chromium.org/189823004/diff/1/tools/bots/bot_utils.py
File tools/bots/bot_utils.py (right):

https://codereview.chromium.org/189823004/diff/1/tools/bots/bot_utils.py#newc...
tools/bots/bot_utils.py:227: raise Exception("Requiring to use dart repo version
of gsutil,"
On 2014/03/07 12:19:53, Bill Hesse wrote:
> Dart repository version of gsutil required, but not found.

Done.

Expand Messages | Collapse Messages