Issue 189583003: Eliminate more implicit getters

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 189583003: Eliminate more implicit getters (Closed)

Created:
6 years, 9 months ago by hausner

Modified:
6 years, 9 months ago

Reviewers:
srdjan

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Eliminate more implicit getters For some reason I don’t remember, we only attempt to optimize away the implicit getter functions of const and final static fields, but not non-final static fields. This change applies the same optimization for all static fields, and also for all top-level fields. R=srdjan@google.com Committed: https://code.google.com/p/dart/source/detail?r=33433

Patch Set 1 #

Created: 6 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+29 lines, -12 lines)			Patch
M	runtime/vm/compiler_stats.h	View	1 chunk	+5 lines, -0 lines	0 comments	Download
M	runtime/vm/compiler_stats.cc	View	2 chunks	+11 lines, -0 lines	0 comments	Download
M	runtime/vm/parser.cc	View	5 chunks	+12 lines, -11 lines	0 comments	Download
M	runtime/vm/service_test.cc	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

hausner

6 years, 9 months ago (2014-03-07 16:20:18 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r33433 (presubmit successful).

Expand Messages | Collapse Messages