Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(193)

Issue 189543013: Add alias identity information to array allocations. (Closed)

Created:
6 years, 9 months ago by Florian Schneider
Modified:
6 years, 9 months ago
Reviewers:
srdjan
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Visibility:
Public.

Description

Add alias identity information to array allocations. Loads/stores with non-escaping arrays can be disambiguated from loads/store with unknown identity. This enables better load elimination for non-escaping arrays. For example in the following code: test() { var a = new List(1); var b = new List(1); a[0] = 42; b[0] = 43; return a[0] + b[0]; } we can now eliminate both loads a[0] and b[0] where before all stores to [0] were considered to interfere with each other.. R=srdjan@google.com Committed: https://code.google.com/p/dart/source/detail?r=33523

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+212 lines, -67 lines) Patch
M runtime/vm/flow_graph_optimizer.cc View 16 chunks +148 lines, -52 lines 0 comments Download
M runtime/vm/intermediate_language.h View 9 chunks +36 lines, -15 lines 0 comments Download
M tests/language/vm/load_to_load_forwarding_vm_test.dart View 1 2 chunks +28 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Florian Schneider
6 years, 9 months ago (2014-03-10 16:02:34 UTC) #1
srdjan
lgtm
6 years, 9 months ago (2014-03-10 22:20:37 UTC) #2
Florian Schneider
6 years, 9 months ago (2014-03-11 09:39:27 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 manually as r33523 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698