Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(144)

Issue 189513003: Add alias disambiguation for VM fields. (Closed)

Created:
6 years, 9 months ago by Florian Schneider
Modified:
6 years, 9 months ago
Reviewers:
srdjan
CC:
reviews_dartlang.org, vm-dev_dartlang.org, Vyacheslav Egorov (Google)
Visibility:
Public.

Description

Add alias disambiguation for VM fields. This is needed for generalizing allocation sinking to work with instance fields and plain field offsets. MaterializeObject now works with a set of Field/Smi objects Right now this should be performance-neutral, but it already simplifies the code be removing the fake fields previously used for type arguments, closure function/context. R=srdjan@google.com Committed: https://code.google.com/p/dart/source/detail?r=33478

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+107 lines, -84 lines) Patch
M runtime/vm/flow_graph_builder.cc View 3 chunks +3 lines, -25 lines 0 comments Download
M runtime/vm/flow_graph_inliner.cc View 1 chunk +3 lines, -14 lines 0 comments Download
M runtime/vm/flow_graph_optimizer.h View 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/flow_graph_optimizer.cc View 10 chunks +93 lines, -32 lines 0 comments Download
M runtime/vm/il_printer.cc View 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/intermediate_language.h View 6 chunks +6 lines, -11 lines 2 comments Download

Messages

Total messages: 4 (0 generated)
Florian Schneider
6 years, 9 months ago (2014-03-07 12:27:04 UTC) #1
srdjan
LGTM with comment https://codereview.chromium.org/189513003/diff/1/runtime/vm/intermediate_language.h File runtime/vm/intermediate_language.h (right): https://codereview.chromium.org/189513003/diff/1/runtime/vm/intermediate_language.h#newcode4075 runtime/vm/intermediate_language.h:4075: class MaterializeObjectInstr : public Definition { ...
6 years, 9 months ago (2014-03-07 17:38:36 UTC) #2
Florian Schneider
https://codereview.chromium.org/189513003/diff/1/runtime/vm/intermediate_language.h File runtime/vm/intermediate_language.h (right): https://codereview.chromium.org/189513003/diff/1/runtime/vm/intermediate_language.h#newcode4075 runtime/vm/intermediate_language.h:4075: class MaterializeObjectInstr : public Definition { On 2014/03/07 17:38:37, ...
6 years, 9 months ago (2014-03-10 09:46:48 UTC) #3
Florian Schneider
6 years, 9 months ago (2014-03-10 09:59:55 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 manually as r33478 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698