Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(352)

Issue 189333002: pkg/docgen: update markdown to 0.5.1 (Closed)

Created:
6 years, 9 months ago by kevmoo
Modified:
6 years, 9 months ago
Reviewers:
Emily Fortuna
CC:
reviews_dartlang.org
Visibility:
Public.

Description

pkg/docgen: update markdown to 0.5.1 updated third_party/pkg/markdown R=efortuna@google.com Committed: https://code.google.com/p/dart/source/detail?r=33404

Patch Set 1 #

Total comments: 2

Patch Set 2 : updates #

Unified diffs Side-by-side diffs Delta from patch set Stats (+205 lines, -1251 lines) Patch
M pkg/docgen/pubspec.yaml View 1 1 chunk +1 line, -4 lines 0 comments Download
M third_party/pkg/markdown/lib/markdown.dart View 1 1 chunk +5 lines, -108 lines 0 comments Download
A + third_party/pkg/markdown/lib/src/ast.dart View 1 1 chunk +3 lines, -1 line 0 comments Download
A + third_party/pkg/markdown/lib/src/block_parser.dart View 1 16 chunks +71 lines, -40 lines 0 comments Download
A + third_party/pkg/markdown/lib/src/document.dart View 1 1 chunk +4 lines, -32 lines 0 comments Download
A + third_party/pkg/markdown/lib/src/html_renderer.dart View 1 1 chunk +21 lines, -1 line 0 comments Download
A + third_party/pkg/markdown/lib/src/inline_parser.dart View 1 1 chunk +5 lines, -1 line 0 comments Download
D third_party/pkg/markdown/lib/src/markdown/ast.dart View 1 1 chunk +0 lines, -65 lines 0 comments Download
D third_party/pkg/markdown/lib/src/markdown/block_parser.dart View 1 1 chunk +0 lines, -503 lines 0 comments Download
D third_party/pkg/markdown/lib/src/markdown/html_renderer.dart View 1 1 chunk +0 lines, -61 lines 0 comments Download
D third_party/pkg/markdown/lib/src/markdown/inline_parser.dart View 1 1 chunk +0 lines, -419 lines 0 comments Download
A third_party/pkg/markdown/lib/src/util.dart View 1 1 chunk +8 lines, -0 lines 0 comments Download
M third_party/pkg/markdown/pubspec.yaml View 1 1 chunk +4 lines, -2 lines 0 comments Download
M third_party/pkg/markdown/test/markdown_test.dart View 1 5 chunks +83 lines, -14 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
kevmoo
Step one: update https://github.com/efortuna/dart-markdown master to https://github.com/dpeek/dart-markdown/commit/ee2b469c1686cb060b9d320f78a7c32cf3c9da3c Then we can push this change and eventually ...
6 years, 9 months ago (2014-03-06 23:04:07 UTC) #1
kevmoo
Hopefully 0.5.1 will get published soon - https://github.com/dpeek/dart-markdown/issues/9
6 years, 9 months ago (2014-03-06 23:06:05 UTC) #2
kevmoo
6 years, 9 months ago (2014-03-06 23:06:15 UTC) #3
Emily Fortuna
https://codereview.chromium.org/189333002/diff/1/pkg/docgen/pubspec.yaml File pkg/docgen/pubspec.yaml (right): https://codereview.chromium.org/189333002/diff/1/pkg/docgen/pubspec.yaml#newcode13 pkg/docgen/pubspec.yaml:13: url: https://github.com/efortuna/dart-markdown we can take out the URL, too. ...
6 years, 9 months ago (2014-03-06 23:11:24 UTC) #4
kevmoo
PTAL https://codereview.chromium.org/189333002/diff/1/pkg/docgen/pubspec.yaml File pkg/docgen/pubspec.yaml (right): https://codereview.chromium.org/189333002/diff/1/pkg/docgen/pubspec.yaml#newcode13 pkg/docgen/pubspec.yaml:13: url: https://github.com/efortuna/dart-markdown On 2014/03/06 23:11:24, Emily Fortuna wrote: ...
6 years, 9 months ago (2014-03-06 23:55:05 UTC) #5
Emily Fortuna
lgtm
6 years, 9 months ago (2014-03-07 00:01:02 UTC) #6
kevmoo
6 years, 9 months ago (2014-03-07 00:01:45 UTC) #7
Message was sent while issue was closed.
Committed patchset #2 manually as r33404 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698