Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(139)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 189293002: Revert "Access to imports in the VM's runtime mirrors. Extend test coverage of the source mirrors." (Closed)

Created:
6 years, 9 months ago by rmacnak
Modified:
6 years, 9 months ago
Reviewers:
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Visibility:
Public.

Description

Revert "Access to imports in the VM's runtime mirrors. Extend test coverage of the source mirrors." Committed: https://code.google.com/p/dart/source/detail?r=33402

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -770 lines) Patch
M runtime/lib/mirrors.cc View 1 chunk +0 lines, -105 lines 0 comments Download
M runtime/lib/mirrors_impl.dart View 2 chunks +0 lines, -42 lines 0 comments Download
M runtime/vm/bootstrap_natives.h View 1 chunk +0 lines, -1 line 0 comments Download
M runtime/vm/object.h View 4 chunks +2 lines, -8 lines 0 comments Download
M runtime/vm/object.cc View 1 chunk +0 lines, -39 lines 0 comments Download
M runtime/vm/parser.h View 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/parser.cc View 3 chunks +4 lines, -9 lines 0 comments Download
M runtime/vm/raw_object.h View 1 chunk +1 line, -3 lines 0 comments Download
M runtime/vm/symbols.h View 1 chunk +0 lines, -2 lines 0 comments Download
M sdk/lib/_internal/lib/js_mirrors.dart View 1 chunk +0 lines, -3 lines 0 comments Download
M sdk/lib/mirrors/mirrors.dart View 1 chunk +0 lines, -45 lines 0 comments Download
M tests/compiler/dart2js/dart2js.status View 1 chunk +0 lines, -7 lines 0 comments Download
D tests/compiler/dart2js/mirrors/library_exports_hidden_test.dart View 1 chunk +0 lines, -17 lines 0 comments Download
D tests/compiler/dart2js/mirrors/library_exports_shown_test.dart View 1 chunk +0 lines, -17 lines 0 comments Download
D tests/compiler/dart2js/mirrors/library_imports_hidden_test.dart View 1 chunk +0 lines, -17 lines 0 comments Download
D tests/compiler/dart2js/mirrors/library_imports_prefixed_show_hide_test.dart View 1 chunk +0 lines, -17 lines 0 comments Download
D tests/compiler/dart2js/mirrors/library_imports_prefixed_test.dart View 1 chunk +0 lines, -17 lines 0 comments Download
D tests/compiler/dart2js/mirrors/library_imports_shown_test.dart View 1 chunk +0 lines, -17 lines 0 comments Download
M tests/lib/lib.status View 1 chunk +0 lines, -8 lines 0 comments Download
D tests/lib/mirrors/library_exports_hidden.dart View 1 chunk +0 lines, -10 lines 0 comments Download
D tests/lib/mirrors/library_exports_hidden_test.dart View 1 chunk +0 lines, -34 lines 0 comments Download
D tests/lib/mirrors/library_exports_shown.dart View 1 chunk +0 lines, -10 lines 0 comments Download
D tests/lib/mirrors/library_exports_shown_test.dart View 1 chunk +0 lines, -35 lines 0 comments Download
D tests/lib/mirrors/library_imports_a.dart View 1 chunk +0 lines, -8 lines 0 comments Download
D tests/lib/mirrors/library_imports_b.dart View 1 chunk +0 lines, -8 lines 0 comments Download
D tests/lib/mirrors/library_imports_bad_metadata_test.dart View 1 chunk +0 lines, -18 lines 0 comments Download
D tests/lib/mirrors/library_imports_hidden.dart View 1 chunk +0 lines, -10 lines 0 comments Download
D tests/lib/mirrors/library_imports_hidden_test.dart View 1 chunk +0 lines, -34 lines 0 comments Download
D tests/lib/mirrors/library_imports_metadata.dart View 1 chunk +0 lines, -17 lines 0 comments Download
D tests/lib/mirrors/library_imports_metadata_test.dart View 1 chunk +0 lines, -50 lines 0 comments Download
D tests/lib/mirrors/library_imports_prefixed.dart View 1 chunk +0 lines, -10 lines 0 comments Download
D tests/lib/mirrors/library_imports_prefixed_show_hide.dart View 1 chunk +0 lines, -10 lines 0 comments Download
D tests/lib/mirrors/library_imports_prefixed_show_hide_test.dart View 1 chunk +0 lines, -33 lines 0 comments Download
D tests/lib/mirrors/library_imports_prefixed_test.dart View 1 chunk +0 lines, -31 lines 0 comments Download
D tests/lib/mirrors/library_imports_shown.dart View 1 chunk +0 lines, -10 lines 0 comments Download
D tests/lib/mirrors/library_imports_shown_test.dart View 1 chunk +0 lines, -34 lines 0 comments Download
M tests/lib/mirrors/stringify.dart View 1 chunk +0 lines, -33 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
rmacnak
6 years, 9 months ago (2014-03-06 22:45:41 UTC) #1
Message was sent while issue was closed. 
Committed patchset #1 manually as r33402 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698