Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(951)

Issue 18920008: Add point to Window class and Window polyfills of screen. (Closed)

Created:
7 years, 5 months ago by Emily Fortuna
Modified:
7 years, 5 months ago
Reviewers:
blois
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Add point to Window class and Window polyfills of screen. BUG= R=blois@google.com Committed: https://code.google.com/p/dart/source/detail?r=24987

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Total comments: 1

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -2 lines) Patch
M sdk/lib/html/dart2js/html_dart2js.dart View 1 2 2 chunks +6 lines, -1 line 0 comments Download
M sdk/lib/html/dartium/html_dartium.dart View 2 chunks +5 lines, -1 line 0 comments Download
M tools/dom/scripts/htmlrenamer.py View 1 1 chunk +1 line, -0 lines 0 comments Download
M tools/dom/templates/html/impl/impl_Window.darttemplate View 1 2 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Emily Fortuna
This is for https://code.google.com/p/dart/issues/detail?id=11675 I went through the suggested methods, but the Point object somehow ...
7 years, 5 months ago (2013-07-13 00:08:07 UTC) #1
blois
https://codereview.chromium.org/18920008/diff/1/sdk/lib/html/dart2js/html_dart2js.dart File sdk/lib/html/dart2js/html_dart2js.dart (right): https://codereview.chromium.org/18920008/diff/1/sdk/lib/html/dart2js/html_dart2js.dart#newcode24562 sdk/lib/html/dart2js/html_dart2js.dart:24562: int get screenX() => Device.isIE ? $dom_screenLeft : $dom_screenX; ...
7 years, 5 months ago (2013-07-13 00:27:24 UTC) #2
Emily Fortuna
removed removal of screenTop/Left.
7 years, 5 months ago (2013-07-13 00:32:00 UTC) #3
blois
lgtm https://codereview.chromium.org/18920008/diff/4001/tools/dom/templates/html/impl/impl_Window.darttemplate File tools/dom/templates/html/impl/impl_Window.darttemplate (right): https://codereview.chromium.org/18920008/diff/4001/tools/dom/templates/html/impl/impl_Window.darttemplate#newcode281 tools/dom/templates/html/impl/impl_Window.darttemplate:281: void moveTo(Point p) => $dom_moveTo(p.x, p.y); I think ...
7 years, 5 months ago (2013-07-13 00:36:05 UTC) #4
Emily Fortuna
7 years, 5 months ago (2013-07-13 00:40:33 UTC) #5
Message was sent while issue was closed.
Committed patchset #3 manually as r24987 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698