Issue 189063006: add indent option to cmdline formatter

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 189063006: add indent option to cmdline formatter (Closed)

Created:
6 years, 9 months ago by danrubel

Modified:
6 years, 9 months ago

Reviewers:
pquitslund

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

add indent option to cmdline formatter BUG=dartbug.com/16991 R=pquitslund@google.com Committed: https://code.google.com/p/dart/source/detail?r=33528

Patch Set 2 : make indent option provisional #

Created: 6 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+75 lines, -3 lines)			Patch
	M	pkg/analyzer/bin/formatter.dart	View	1	3 chunks	+26 lines, -3 lines	0 comments	Download
	M	pkg/analyzer/test/services/formatter_test.dart	View		2 chunks	+49 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

pquitslund

LGTM % comments. https://codereview.chromium.org/189063006/diff/1/pkg/analyzer/bin/formatter.dart File pkg/analyzer/bin/formatter.dart (right): https://codereview.chromium.org/189063006/diff/1/pkg/analyzer/bin/formatter.dart#newcode200 pkg/analyzer/bin/formatter.dart:200: 'To indent using tabs, specify "--$INDENT_FLAG ...

6 years, 9 months ago (2014-03-07 19:21:45 UTC) #2

danrubel

https://codereview.chromium.org/189063006/diff/1/pkg/analyzer/bin/formatter.dart File pkg/analyzer/bin/formatter.dart (right): https://codereview.chromium.org/189063006/diff/1/pkg/analyzer/bin/formatter.dart#newcode200 pkg/analyzer/bin/formatter.dart:200: 'To indent using tabs, specify "--$INDENT_FLAG tab".'); On 2014/03/07 ...

6 years, 9 months ago (2014-03-11 14:22:35 UTC) #3

danrubel

6 years, 9 months ago (2014-03-11 14:29:20 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 manually as r33528 (presubmit successful).

Expand Messages | Collapse Messages

Issue 189063006: add indent option to cmdline formatter (Closed)

Description

Patch Set 1 #

Patch Set 2 : make indent option provisional #

Messages