Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(364)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 189043003: Improved 'has' properties translation. (Closed)

Created:
6 years, 9 months ago by scheglov
Modified:
6 years, 9 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Improved 'has' properties translation. New analyzer snapshot. R=brianwilkerson@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=33399

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+1991 lines, -1849 lines) Patch
M editor/util/plugins/com.google.dart.java2dart/src/com/google/dart/java2dart/engine/EngineInstanceOfProcessor.java View 2 chunks +2 lines, -2 lines 0 comments Download
M editor/util/plugins/com.google.dart.java2dart/src/com/google/dart/java2dart/processor/PropertySemanticProcessor.java View 1 chunk +9 lines, -2 lines 1 comment Download
M editor/util/plugins/com.google.dart.java2dart_test/src/com/google/dart/java2dart/processor/PropertySemanticProcessorTest.java View 2 chunks +64 lines, -0 lines 0 comments Download
M pkg/analyzer/example/resolver_driver.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analyzer/lib/src/generated/ast.dart View 6 chunks +10 lines, -8 lines 0 comments Download
M pkg/analyzer/lib/src/generated/constant.dart View 13 chunks +15 lines, -15 lines 0 comments Download
M pkg/analyzer/lib/src/generated/element.dart View 23 chunks +26 lines, -26 lines 0 comments Download
M pkg/analyzer/lib/src/generated/engine.dart View 123 chunks +341 lines, -313 lines 0 comments Download
M pkg/analyzer/lib/src/generated/error.dart View 54 chunks +80 lines, -73 lines 0 comments Download
M pkg/analyzer/lib/src/generated/html.dart View 15 chunks +38 lines, -38 lines 0 comments Download
M pkg/analyzer/lib/src/generated/index.dart View 12 chunks +81 lines, -81 lines 0 comments Download
M pkg/analyzer/lib/src/generated/parser.dart View 8 chunks +8 lines, -8 lines 0 comments Download
M pkg/analyzer/lib/src/generated/resolver.dart View 214 chunks +404 lines, -414 lines 0 comments Download
M pkg/analyzer/lib/src/generated/scanner.dart View 28 chunks +52 lines, -52 lines 1 comment Download
M pkg/analyzer/lib/src/generated/sdk_io.dart View 5 chunks +5 lines, -5 lines 0 comments Download
M pkg/analyzer/lib/src/generated/source.dart View 3 chunks +3 lines, -3 lines 0 comments Download
M pkg/analyzer/lib/src/generated/utilities_collection.dart View 4 chunks +14 lines, -14 lines 0 comments Download
M pkg/analyzer/pubspec.yaml View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analyzer/test/generated/ast_test.dart View 19 chunks +147 lines, -147 lines 0 comments Download
M pkg/analyzer/test/generated/element_test.dart View 10 chunks +21 lines, -21 lines 0 comments Download
M pkg/analyzer/test/generated/parser_test.dart View 146 chunks +240 lines, -241 lines 0 comments Download
M pkg/analyzer/test/generated/resolver_test.dart View 170 chunks +331 lines, -276 lines 0 comments Download
M pkg/analyzer/test/generated/scanner_test.dart View 33 chunks +37 lines, -37 lines 0 comments Download
M pkg/analyzer/test/generated/test_support.dart View 15 chunks +53 lines, -63 lines 0 comments Download
M pkg/code_transformers/lib/src/resolver_impl.dart View 3 chunks +4 lines, -4 lines 0 comments Download
M pkg/code_transformers/pubspec.yaml View 1 chunk +1 line, -1 line 0 comments Download
M pkg/intl/pubspec.yaml View 1 chunk +1 line, -1 line 0 comments Download
M pkg/observe/pubspec.yaml View 1 chunk +1 line, -1 line 0 comments Download
M pkg/polymer/pubspec.yaml View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
scheglov
6 years, 9 months ago (2014-03-06 21:05:59 UTC) #1
Brian Wilkerson
LGTM https://codereview.chromium.org/189043003/diff/1/editor/util/plugins/com.google.dart.java2dart/src/com/google/dart/java2dart/processor/PropertySemanticProcessor.java File editor/util/plugins/com.google.dart.java2dart/src/com/google/dart/java2dart/processor/PropertySemanticProcessor.java (right): https://codereview.chromium.org/189043003/diff/1/editor/util/plugins/com.google.dart.java2dart/src/com/google/dart/java2dart/processor/PropertySemanticProcessor.java#newcode286 editor/util/plugins/com.google.dart.java2dart/src/com/google/dart/java2dart/processor/PropertySemanticProcessor.java:286: } else if (hasPrefix(name, "is")) { Not sure ...
6 years, 9 months ago (2014-03-06 21:31:55 UTC) #2
scheglov
6 years, 9 months ago (2014-03-06 22:18:44 UTC) #3
Message was sent while issue was closed. 
Committed patchset #1 manually as r33399 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698