Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(134)

Issue 1890003002: Fix a race condition. (Closed)

Created:
4 years, 8 months ago by nweiz
Modified:
4 years, 8 months ago
Reviewers:
Jennifer Messerly
CC:
reviews_dartlang.org, Bob Nystrom
Base URL:
git@github.com:dart-lang/json_rpc_2.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix a race condition. If the peer was closed and then the channel closed, we would double-complete a completer. R=jmesserly@google.com Committed: https://github.com/dart-lang/json_rpc_2/commit/9dfdeb5e0425a89b9859e47cb0d14be9e0930e50

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -2 lines) Patch
M CHANGELOG.md View 1 chunk +5 lines, -0 lines 0 comments Download
M lib/src/channel_manager.dart View 1 chunk +3 lines, -1 line 0 comments Download
M pubspec.yaml View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (1 generated)
nweiz
4 years, 8 months ago (2016-04-14 22:08:42 UTC) #1
Jennifer Messerly
lgtm!
4 years, 8 months ago (2016-04-14 22:12:09 UTC) #2
nweiz
4 years, 8 months ago (2016-04-14 22:18:38 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
9dfdeb5e0425a89b9859e47cb0d14be9e0930e50 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698