Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(51)

Issue 18892003: Roll forward "Use package:stack_trace in unittest." (Closed)

Created:
7 years, 5 months ago by nweiz
Modified:
7 years, 5 months ago
Reviewers:
vsm, siva
CC:
reviews_dartlang.org, Emily Fortuna, siva, gram
Visibility:
Public.

Description

Roll forward "Use package:stack_trace in unittest." This reverts r24669 and rolls forward r24652, r24659, and r24661. BUG=11649 R=asiva@google.com, vsm@google.com Committed: https://code.google.com/p/dart/source/detail?r=25131

Patch Set 1 #

Patch Set 2 : Merge head. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+103 lines, -127 lines) Patch
M pkg/unittest/lib/compact_vm_config.dart View 1 3 chunks +4 lines, -7 lines 0 comments Download
M pkg/unittest/lib/html_config.dart View 1 chunk +3 lines, -1 line 0 comments Download
M pkg/unittest/lib/html_enhanced_config.dart View 1 chunk +2 lines, -1 line 0 comments Download
M pkg/unittest/lib/interactive_html_config.dart View 4 chunks +23 lines, -6 lines 0 comments Download
M pkg/unittest/lib/src/config.dart View 5 chunks +16 lines, -22 lines 0 comments Download
M pkg/unittest/lib/src/test_case.dart View 6 chunks +7 lines, -12 lines 0 comments Download
M pkg/unittest/lib/src/utils.dart View 1 chunk +21 lines, -0 lines 0 comments Download
M pkg/unittest/lib/unittest.dart View 5 chunks +24 lines, -76 lines 0 comments Download
M pkg/unittest/pubspec.yaml View 1 chunk +1 line, -1 line 0 comments Download
M tests/standalone/standalone.status View 1 1 chunk +1 line, -0 lines 0 comments Download
M utils/testrunner/standard_test_runner.dart View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
nweiz
Rolling this forward to see if it breaks anything and hopefully to handle the breakages ...
7 years, 5 months ago (2013-07-17 21:02:17 UTC) #1
vsm
lgtm
7 years, 5 months ago (2013-07-17 21:03:16 UTC) #2
siva
lgtm
7 years, 5 months ago (2013-07-17 21:17:34 UTC) #3
nweiz
7 years, 5 months ago (2013-07-17 22:39:53 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 manually as r25131 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698