Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(175)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1887853002: Add a LiveSuite class. (Closed)

Created:
4 years, 8 months ago by nweiz
Modified:
4 years, 7 months ago
Reviewers:
kevmoo
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/test@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Add a LiveSuite class. Internal users want to use this. R=kevmoo@google.com Committed: https://github.com/dart-lang/test/commit/9ec7235a1e9297f1851ba4c0b9d33f6673f2421e

Patch Set 1 #

Total comments: 2

Patch Set 2 : Code review changes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+429 lines, -97 lines) Patch
M dart_test.yaml View 1 chunk +4 lines, -0 lines 0 comments Download
M lib/src/backend/invoker.dart View 2 chunks +4 lines, -3 lines 0 comments Download
M lib/src/runner/engine.dart View 13 chunks +134 lines, -91 lines 0 comments Download
A lib/src/runner/live_suite.dart View 1 chunk +88 lines, -0 lines 0 comments Download
A lib/src/runner/live_suite_controller.dart View 1 1 chunk +155 lines, -0 lines 0 comments Download
A lib/src/util/iterable_set.dart View 1 chunk +35 lines, -0 lines 0 comments Download
M pubspec.yaml View 2 chunks +4 lines, -1 line 0 comments Download
M test/io.dart View 2 chunks +2 lines, -0 lines 0 comments Download
M test/runner/configuration/top_level_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M test/runner/json_reporter_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M test/runner/pub_serve_test.dart View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 7 (1 generated)
nweiz
4 years, 8 months ago (2016-04-13 23:05:15 UTC) #1
nweiz
Note that landing this is blocked on https://codereview.chromium.org/1873373002/, but I'd prefer not to block the ...
4 years, 8 months ago (2016-04-13 23:05:42 UTC) #2
kevmoo
LGTM w/ one comment assuming this won't land until the collection fun is figured out ...
4 years, 8 months ago (2016-04-14 01:11:24 UTC) #3
nweiz
Code review changes
4 years, 8 months ago (2016-04-14 19:21:46 UTC) #4
nweiz
https://codereview.chromium.org/1887853002/diff/1/lib/src/runner/live_suite_controller.dart File lib/src/runner/live_suite_controller.dart (right): https://codereview.chromium.org/1887853002/diff/1/lib/src/runner/live_suite_controller.dart#newcode15 lib/src/runner/live_suite_controller.dart:15: /// An implementation of [LiveSuite] that's controlled by a ...
4 years, 8 months ago (2016-04-14 19:21:53 UTC) #5
nweiz
4 years, 7 months ago (2016-05-04 23:12:59 UTC) #7
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as
9ec7235a1e9297f1851ba4c0b9d33f6673f2421e (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698