add option to pick up hosted url from an anvironment variable

add option to pick up hosted url from an anvironment variable

R=rnystrom@google.com

Committed: https://code.google.com/p/dart/source/detail?r=25014

[Bob Nystrom, 2013-07-12 21:50:59]

https://codereview.chromium.org/18878005/diff/2001/sdk/lib/_internal/pub/lib/...
File sdk/lib/_internal/pub/lib/src/source/hosted.dart (right):

https://codereview.chromium.org/18878005/diff/2001/sdk/lib/_internal/pub/lib/...
sdk/lib/_internal/pub/lib/src/source/hosted.dart:28: static String DEFAULT_URL =
url;
Delete this and then replace references to it with "defaultUrl".

https://codereview.chromium.org/18878005/diff/2001/sdk/lib/_internal/pub/lib/...
sdk/lib/_internal/pub/lib/src/source/hosted.dart:33: /// Get the url for the
hosted package repository
"Gets the default URL for the package server for hosted dependencies."

https://codereview.chromium.org/18878005/diff/2001/sdk/lib/_internal/pub/lib/...
sdk/lib/_internal/pub/lib/src/source/hosted.dart:34: static String get url {
"url" -> "defaultUrl".

https://codereview.chromium.org/18878005/diff/2001/sdk/lib/_internal/pub/lib/...
sdk/lib/_internal/pub/lib/src/source/hosted.dart:35: var hosturl =
io.Platform.environment["PUB_HOSTED_URL"];
"hosturl" -> "url"

https://codereview.chromium.org/18878005/diff/2001/sdk/lib/_internal/pub/lib/...
sdk/lib/_internal/pub/lib/src/source/hosted.dart:37: return hosturl;
Just make this a one line statement. If the then body is on the next line, it
should have curlies.

[keertip, 2013-07-12 23:23:18]

https://codereview.chromium.org/18878005/diff/2001/sdk/lib/_internal/pub/lib/...
File sdk/lib/_internal/pub/lib/src/source/hosted.dart (right):

https://codereview.chromium.org/18878005/diff/2001/sdk/lib/_internal/pub/lib/...
sdk/lib/_internal/pub/lib/src/source/hosted.dart:28: static String DEFAULT_URL =
url;
On 2013/07/12 21:50:59, Bob Nystrom wrote:
> Delete this and then replace references to it with "defaultUrl".

Done.

https://codereview.chromium.org/18878005/diff/2001/sdk/lib/_internal/pub/lib/...
sdk/lib/_internal/pub/lib/src/source/hosted.dart:33: /// Get the url for the
hosted package repository
On 2013/07/12 21:50:59, Bob Nystrom wrote:
> "Gets the default URL for the package server for hosted dependencies."

Done.

https://codereview.chromium.org/18878005/diff/2001/sdk/lib/_internal/pub/lib/...
sdk/lib/_internal/pub/lib/src/source/hosted.dart:34: static String get url {
On 2013/07/12 21:50:59, Bob Nystrom wrote:
> "url" -> "defaultUrl".

Done.

https://codereview.chromium.org/18878005/diff/2001/sdk/lib/_internal/pub/lib/...
sdk/lib/_internal/pub/lib/src/source/hosted.dart:35: var hosturl =
io.Platform.environment["PUB_HOSTED_URL"];
On 2013/07/12 21:50:59, Bob Nystrom wrote:
> "hosturl" -> "url"

Done.

https://codereview.chromium.org/18878005/diff/2001/sdk/lib/_internal/pub/lib/...
sdk/lib/_internal/pub/lib/src/source/hosted.dart:37: return hosturl;
On 2013/07/12 21:50:59, Bob Nystrom wrote:
> Just make this a one line statement. If the then body is on the next line, it
> should have curlies.

Done.

[Bob Nystrom, 2013-07-15 15:40:38]

One nit then LGTM.

https://codereview.chromium.org/18878005/diff/8001/sdk/lib/_internal/pub/lib/...
File sdk/lib/_internal/pub/lib/src/source/hosted.dart (right):

https://codereview.chromium.org/18878005/diff/8001/sdk/lib/_internal/pub/lib/...
sdk/lib/_internal/pub/lib/src/source/hosted.dart:33: var url=
io.Platform.environment["PUB_HOSTED_URL"];
Space before "=".

[keertip, 2013-07-15 15:42:02]

https://codereview.chromium.org/18878005/diff/8001/sdk/lib/_internal/pub/lib/...
File sdk/lib/_internal/pub/lib/src/source/hosted.dart (right):

https://codereview.chromium.org/18878005/diff/8001/sdk/lib/_internal/pub/lib/...
sdk/lib/_internal/pub/lib/src/source/hosted.dart:33: var url=
io.Platform.environment["PUB_HOSTED_URL"];
On 2013/07/15 15:40:38, Bob Nystrom wrote:
> Space before "=".

Done.

[keertip, 2013-07-15 18:07:53]

Committed patchset #5 manually as r25014 (presubmit successful).