Issue 18878003: Fix pathos->path in watcher example.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 18878003: Fix pathos->path in watcher example. (Closed)

Created:
7 years, 5 months ago by Bob Nystrom

Modified:
7 years, 5 months ago

Reviewers:
nweiz

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Fix pathos->path in watcher example. BUG= R=nweiz@google.com Committed: https://code.google.com/p/dart/source/detail?r=24976

Patch Set 2 : Use "p" prefix for path. #

Patch Set 3 : Use "p" prefix for path. #

Created: 7 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+12 lines, -12 lines)			Patch
	M	pkg/watcher/example/watch.dart	View	1	2 chunks	+2 lines, -2 lines	0 comments	Download
	M	pkg/watcher/test/utils.dart	View	1	6 chunks	+10 lines, -10 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Bob Nystrom

Fixed the other references to pathos in the main watcher patch, but missed this one.

7 years, 5 months ago (2013-07-12 21:17:28 UTC) #1

nweiz

One comment, otherwise lgtm. https://codereview.chromium.org/18878003/diff/1/pkg/watcher/example/watch.dart File pkg/watcher/example/watch.dart (right): https://codereview.chromium.org/18878003/diff/1/pkg/watcher/example/watch.dart#newcode10 pkg/watcher/example/watch.dart:10: import 'package:path/path.dart'; This should be ...

7 years, 5 months ago (2013-07-12 21:21:49 UTC) #2