Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(262)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 18877005: Split up tests and add some heartbeats to try to make them not timeout. (Closed)

Created:
7 years, 5 months ago by Bob Nystrom
Modified:
7 years, 5 months ago
Reviewers:
nweiz
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Split up tests and add some heartbeats to try to make them not timeout. BUG= R=nweiz@google.com Committed: https://code.google.com/p/dart/source/detail?r=24978

Patch Set 1 #

Patch Set 2 : Increase timeout of slow test. #

Patch Set 3 : Make poll delay configurable. #

Patch Set 4 : Fix cut/paste error. #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+195 lines, -149 lines) Patch
M pkg/watcher/lib/src/directory_watcher.dart View 1 2 2 chunks +13 lines, -2 lines 0 comments Download
M pkg/watcher/test/directory_watcher_test.dart View 1 chunk +0 lines, -146 lines 0 comments Download
A pkg/watcher/test/no_subscription_test.dart View 1 2 1 chunk +73 lines, -0 lines 0 comments Download
A pkg/watcher/test/ready_test.dart View 1 2 3 1 chunk +106 lines, -0 lines 0 comments Download
M pkg/watcher/test/utils.dart View 1 2 1 chunk +3 lines, -1 line 1 comment Download

Messages

Total messages: 3 (0 generated)
nweiz
lgtm https://codereview.chromium.org/18877005/diff/11001/pkg/watcher/test/utils.dart File pkg/watcher/test/utils.dart (right): https://codereview.chromium.org/18877005/diff/11001/pkg/watcher/test/utils.dart#newcode82 pkg/watcher/test/utils.dart:82: pollingDelay: new Duration(milliseconds: 100)); This could probably be ...
7 years, 5 months ago (2013-07-12 22:37:16 UTC) #1
Bob Nystrom
Committed patchset #4 manually as r24978 (presubmit successful).
7 years, 5 months ago (2013-07-12 22:45:49 UTC) #2
Bob Nystrom
7 years, 5 months ago (2013-07-12 22:46:16 UTC) #3
Message was sent while issue was closed. 
On 2013/07/12 22:37:16, nweiz wrote:
> lgtm
> 
>
https://codereview.chromium.org/18877005/diff/11001/pkg/watcher/test/utils.dart
> File pkg/watcher/test/utils.dart (right):
> 
>
https://codereview.chromium.org/18877005/diff/11001/pkg/watcher/test/utils.da...
> pkg/watcher/test/utils.dart:82: pollingDelay: new Duration(milliseconds:
100));
> This could probably be 0s or something vanishingly small without any adverse
> effects.

100ms should be pretty fast (all of the tests finish in under 3s on my machine)
and tries to kinda sorta be closer to real-world usage.

Powered by Google App Engine
This is Rietveld 408576698