dart:io | Fix SecureSocket client certificate problem with database password.

dart:io | Fix SecureSocket client certificate problem with database password.

BUG=
R=ajohnsen@google.com

Committed: https://code.google.com/p/dart/source/detail?r=24907

[Bill Hesse, 2013-07-09 14:08:23]

The password callback needs to be installed both for server sockets and client
sockets, and the PIN needs to be set for some functions.  The PIN setting could
be moved up to where _filter is created.  The password callback doesn't need to
be set if the default database is used, but it could be, without harm.

[Anders Johnsen, 2013-07-11 08:17:42]

Is there a bug for this? If so, please assign it.

LGTM.

https://codereview.chromium.org/18876003/diff/1/runtime/bin/secure_socket.cc
File runtime/bin/secure_socket.cc (right):

https://codereview.chromium.org/18876003/diff/1/runtime/bin/secure_socket.cc#...
runtime/bin/secure_socket.cc:531: return PL_strdup(static_cast<char*>(arg));  //
Freed by NSS internals.
Why PL_strdup here but strdup below?

https://codereview.chromium.org/18876003/diff/1/runtime/bin/secure_socket.cc#...
runtime/bin/secure_socket.cc:590: password_ = strdup(password);  // This one
copy persists until Dart exits.
Dart exits or leaving the current Dart Scope?

https://codereview.chromium.org/18876003/diff/1/runtime/bin/secure_socket.cc#...
runtime/bin/secure_socket.cc:758: SSL_SetPKCS11PinArg(filter_,
const_cast<char*>(password_));
delete password_ in destructor?

[Bill Hesse, 2013-07-11 09:24:45]

There is no bug about this issue - I discovered it while writing tests for SSL
renegotiation that ran client and server in separate processes.

https://codereview.chromium.org/18876003/diff/1/runtime/bin/secure_socket.cc
File runtime/bin/secure_socket.cc (right):

https://codereview.chromium.org/18876003/diff/1/runtime/bin/secure_socket.cc#...
runtime/bin/secure_socket.cc:590: password_ = strdup(password);  // This one
copy persists until Dart exits.
On 2013/07/11 08:17:43, Anders Johnsen wrote:
> Dart exits or leaving the current Dart Scope?

Until Dart exits (the process terminates).  This initialization occurs once per
process.

We use strdup because this is our copy, that is never freed.  PR_strdup
allocates within the heap managed by NSS.

 We use PR_strdup in the password callback because there is a corresponding
PR_free inside the code that calls this callback.

https://codereview.chromium.org/18876003/diff/1/runtime/bin/secure_socket.cc#...
runtime/bin/secure_socket.cc:758: SSL_SetPKCS11PinArg(filter_,
const_cast<char*>(password_));
On 2013/07/11 08:17:43, Anders Johnsen wrote:
> delete password_ in destructor?

No, password_ is a static.

[Bill Hesse, 2013-07-11 10:02:18]

Committed patchset #1 manually as r24907 (presubmit successful).