Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(361)

Issue 188703004: Fix invocation of closures via .call in the VM (Closed)

Created:
6 years, 9 months ago by Florian Schneider
Modified:
6 years, 9 months ago
Reviewers:
Ivan Posva
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Visibility:
Public.

Description

Fix invocation of closures via .call in the VM. Calling closures via .call does now work in the VM - it was working in dart2js already. Calling .call on a closure is implemented to go through a dispatcher method. These dispatcher methods are automatically created and cached in the same way as NoSuchMethod- or field-invocation dispatchers. This CL does not change the way regular closure invocation works in the VM. It is therefore performance-neutral for normal closure calls. BUG=dartbug.com/12602 TEST=language/call_test R=iposva@google.com Committed: https://code.google.com/p/dart/source/detail?r=33576

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+119 lines, -12 lines) Patch
M runtime/vm/code_generator.cc View 1 1 chunk +12 lines, -5 lines 0 comments Download
M runtime/vm/debugger.cc View 1 1 chunk +1 line, -0 lines 0 comments Download
M runtime/vm/object.h View 1 2 chunks +5 lines, -0 lines 0 comments Download
M runtime/vm/object.cc View 1 6 chunks +15 lines, -4 lines 0 comments Download
M runtime/vm/parser.h View 1 1 chunk +2 lines, -0 lines 0 comments Download
M runtime/vm/parser.cc View 1 2 chunks +51 lines, -0 lines 0 comments Download
M runtime/vm/raw_object.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M tests/language/call_test.dart View 1 2 chunks +32 lines, -2 lines 0 comments Download
M tests/language/language.status View 1 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
Florian Schneider
6 years, 9 months ago (2014-03-12 10:06:31 UTC) #1
Ivan Posva
LGTM -ip
6 years, 9 months ago (2014-03-12 13:32:18 UTC) #2
Florian Schneider
6 years, 9 months ago (2014-03-12 14:02:43 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 manually as r33576 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698