Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(351)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 188673004: Roll forward commits r33138, r33135, and r33134. (Closed)

Created:
6 years, 9 months ago by nweiz
Modified:
6 years, 9 months ago
Reviewers:
Bob Nystrom
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Roll forward commits r33138, r33135, and r33134. These commits were rolled back because r33134 exposed a case where barback was able to deadlock. r33391 removed the root cause of the deadlock, so these commits can be rolled forward again. R=rnystrom@google.com BUG=16612 Committed: https://code.google.com/p/dart/source/detail?r=33400

Patch Set 1 #

Patch Set 2 : re-upload #

Total comments: 2

Patch Set 3 : code review #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1573 lines, -1333 lines) Patch
A pkg/barback/lib/src/asset_node_set.dart View 1 chunk +24 lines, -0 lines 0 comments Download
M pkg/barback/lib/src/phase_forwarder.dart View 3 chunks +3 lines, -6 lines 0 comments Download
M pkg/barback/lib/src/phase_input.dart View 9 chunks +55 lines, -33 lines 0 comments Download
M pkg/barback/lib/src/transform_node.dart View 5 chunks +12 lines, -6 lines 0 comments Download
M pkg/barback/pubspec.yaml View 1 chunk +1 line, -0 lines 0 comments Download
M pkg/barback/test/package_graph/add_remove_transform_test.dart View 6 chunks +102 lines, -21 lines 0 comments Download
M pkg/barback/test/package_graph/errors_test.dart View 1 chunk +0 lines, -9 lines 0 comments Download
M pkg/barback/test/package_graph/get_all_assets_test.dart View 1 chunk +11 lines, -11 lines 0 comments Download
M pkg/barback/test/package_graph/group_test.dart View 11 chunks +43 lines, -63 lines 0 comments Download
M pkg/barback/test/package_graph/lazy_transformer_test.dart View 1 chunk +1 line, -1 line 0 comments Download
A pkg/barback/test/package_graph/transform/concurrency_test.dart View 1 chunk +473 lines, -0 lines 0 comments Download
A pkg/barback/test/package_graph/transform/cross_package_test.dart View 1 chunk +226 lines, -0 lines 0 comments Download
A pkg/barback/test/package_graph/transform/pass_through_test.dart View 1 chunk +273 lines, -0 lines 0 comments Download
A pkg/barback/test/package_graph/transform/transform_test.dart View 1 chunk +344 lines, -0 lines 0 comments Download
D pkg/barback/test/package_graph/transform_test.dart View 1 chunk +0 lines, -1179 lines 0 comments Download
M pkg/barback/test/utils.dart View 2 chunks +5 lines, -4 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
nweiz
6 years, 9 months ago (2014-03-06 20:24:45 UTC) #1
Bob Nystrom
LGTM. https://codereview.chromium.org/188673004/diff/20001/pkg/barback/lib/src/group_runner.dart File pkg/barback/lib/src/group_runner.dart (right): https://codereview.chromium.org/188673004/diff/20001/pkg/barback/lib/src/group_runner.dart#newcode11 pkg/barback/lib/src/group_runner.dart:11: import 'asset_node_set.dart'; Is this needed?
6 years, 9 months ago (2014-03-06 21:29:35 UTC) #2
nweiz
https://codereview.chromium.org/188673004/diff/20001/pkg/barback/lib/src/group_runner.dart File pkg/barback/lib/src/group_runner.dart (right): https://codereview.chromium.org/188673004/diff/20001/pkg/barback/lib/src/group_runner.dart#newcode11 pkg/barback/lib/src/group_runner.dart:11: import 'asset_node_set.dart'; On 2014/03/06 21:29:36, Bob Nystrom wrote: > ...
6 years, 9 months ago (2014-03-06 22:24:28 UTC) #3
nweiz
6 years, 9 months ago (2014-03-06 22:28:22 UTC) #4
Message was sent while issue was closed. 
Committed patchset #3 manually as r33400 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698