Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(606)

Issue 18859003: Fix status file. (Closed)

Created:
7 years, 5 months ago by floitsch
Modified:
7 years, 5 months ago
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M tests/lib/lib.status View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
floitsch
TBR.
7 years, 5 months ago (2013-07-08 16:34:33 UTC) #1
floitsch
Committed patchset #1 manually as r24803 (presubmit successful).
7 years, 5 months ago (2013-07-08 16:34:42 UTC) #2
Lasse Reichstein Nielsen
LGTM. Thanks for fixing my butterfingers.
7 years, 5 months ago (2013-07-09 05:58:29 UTC) #3
kustermann
7 years, 5 months ago (2013-07-09 15:51:33 UTC) #4
Message was sent while issue was closed.
@floitsch/@lrn: Most dart2js builders are red since this change (or rather lrn's
original change). I'm pretty sure you got a friendly mail from the buildbot.

Would be nice if you could get the builders green again. I don't know what the
expected behavior here is. Does dart2js support Float32x4 or not?

 
http://build.chromium.org/p/client.dart/builders/dart2js-linux-release-checke...
    ...
    throw $.wrapException($.UnsupportedError$("Float32x4 not supported by dart2j
    ...

Powered by Google App Engine
This is Rietveld 408576698