Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(317)

Issue 18855009: Update idlsync.py to work with chrome generator. (Closed)

Created:
7 years, 5 months ago by benwells
Modified:
7 years, 5 months ago
Reviewers:
vsm, antonm
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Update idlsync.py to work with chrome generator. BUG=None R=vsm@google.com Committed: https://code.google.com/p/dart/source/detail?r=24871

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -21 lines) Patch
M tools/dom/scripts/chromegenerator.py View 1 chunk +2 lines, -2 lines 0 comments Download
M tools/dom/scripts/idlsync.py View 5 chunks +20 lines, -19 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
benwells
Update some paths and changed the Save / Restore version control code to work with ...
7 years, 5 months ago (2013-07-09 02:08:37 UTC) #1
benwells
On 2013/07/09 02:08:37, benwells wrote: > Update some paths and changed the Save / Restore ...
7 years, 5 months ago (2013-07-09 02:23:25 UTC) #2
vsm
lgtm
7 years, 5 months ago (2013-07-09 05:20:29 UTC) #3
benwells
On 2013/07/09 05:20:29, vsm wrote: > lgtm Hmm, am getting an error when I try ...
7 years, 5 months ago (2013-07-09 07:23:35 UTC) #4
benwells
Committed patchset #1 manually as r24871 (presubmit successful).
7 years, 5 months ago (2013-07-10 00:29:55 UTC) #5
benwells
7 years, 5 months ago (2013-07-10 00:30:45 UTC) #6
Message was sent while issue was closed.
On 2013/07/10 00:29:55, benwells wrote:
> Committed patchset #1 manually as r24871 (presubmit successful).

Tried again today and it Just Worked.

Powered by Google App Engine
This is Rietveld 408576698