Issue 18841002: Address more bot-redness.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 18841002: Address more bot-redness. (Closed)

Created:
7 years, 5 months ago by Lasse Reichstein Nielsen

Modified:
7 years, 5 months ago

Reviewers:
floitsch

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Address more bot-redness. Committed: https://code.google.com/p/dart/source/detail?r=24794

Patch Set 1 #

Total comments: 2

Created: 7 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -3 lines)			Patch
	M	tests/lib/async/event_helper.dart	View		2 chunks	+2 lines, -2 lines	0 comments	Download
	M	tests/lib/lib.status	View		2 chunks	+3 lines, -1 line	2 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

floitsch

LGTM. https://codereview.chromium.org/18841002/diff/1/tests/lib/lib.status File tests/lib/lib.status (right): https://codereview.chromium.org/18841002/diff/1/tests/lib/lib.status#newcode56 tests/lib/lib.status:56: [ $compiler == dart2js && ($jscl || $runtime ...

7 years, 5 months ago (2013-07-08 12:01:34 UTC) #2

Lasse Reichstein Nielsen

Committed patchset #1 manually as r24794 (presubmit successful).

7 years, 5 months ago (2013-07-08 12:24:37 UTC) #3

Lasse Reichstein Nielsen

7 years, 5 months ago (2013-07-08 12:38:34 UTC) #4

Message was sent while issue was closed.

https://codereview.chromium.org/18841002/diff/1/tests/lib/lib.status
File tests/lib/lib.status (right):

https://codereview.chromium.org/18841002/diff/1/tests/lib/lib.status#newcode56
tests/lib/lib.status:56: [ $compiler == dart2js && ($jscl || $runtime == d8)
]async/stream_controller_async_test: Fail # Timer interface not supported;
dartbug.com/7728.
On 2013/07/08 12:01:34, floitsch wrote:
> Missing new line.

Done.

Expand Messages | Collapse Messages