Issue 18829003: - Use TCP_NODELAY when using the coverage tool.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 18829003: - Use TCP_NODELAY when using the coverage tool. (Closed)

Created:
7 years, 5 months ago by Ivan Posva

Modified:
7 years, 5 months ago

Reviewers:
siva, hausner

CC:
reviews_dartlang.org, Anders Johnsen

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

- Use TCP_NODELAY when using the coverage tool and ddbg. - Use IPPROTO_TCP instead of SOL_TCP for increased portability. R=asiva@google.com, hausner@google.com Committed: https://code.google.com/p/dart/source/detail?r=24865

Created: 7 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -2 lines)			Patch
M	runtime/bin/dbg_connection.cc	View	1 2 3	1 chunk	+1 line, -0 lines	0 comments	Download
M	runtime/bin/socket_android.cc	View	1 2 3	1 chunk	+1 line, -1 line	0 comments	Download
M	runtime/bin/socket_linux.cc	View	1 2 3	1 chunk	+1 line, -1 line	0 comments	Download
M	tests/standalone/debugger/debug_lib.dart	View	1 2 3	1 chunk	+1 line, -0 lines	0 comments	Download
M	tools/coverage.dart	View	1 2 3	1 chunk	+1 line, -0 lines	0 comments	Download
M	tools/ddbg.dart	View	1 2 3	1 chunk	+1 line, -0 lines	0 comments	Download

Total messages: 5 (0 generated)

hausner

LGTM. There is one more place where the nodelay option should be set. Please check ...

7 years, 5 months ago (2013-07-09 17:05:43 UTC) #3

Ivan Posva

On 2013/07/09 17:05:43, hausner wrote: > LGTM. > > There is one more place where ...

7 years, 5 months ago (2013-07-09 21:07:39 UTC) #4

Ivan Posva

7 years, 5 months ago (2013-07-09 21:14:36 UTC) #5

Message was sent while issue was closed.

Committed patchset #4 manually as r24865 (presubmit successful).