Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(215)

Issue 18826010: When using content_shell to run tests, run them with '--single-process' (Closed)

Created:
7 years, 5 months ago by kustermann
Modified:
7 years, 5 months ago
Reviewers:
Bill Hesse
CC:
reviews_dartlang.org, ricow1
Visibility:
Public.

Description

When using content_shell to run tests, run them with '--single-process' It seems that the exit code of the renderer process is not correctly propagated to content_shell (at least on windows). By passing the '--single-process' flag to content_shell, we ensure that we can detect renderer crashes. R=whesse@google.com Committed: https://code.google.com/p/dart/source/detail?r=24840

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M tools/testing/dart/test_suite.dart View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
kustermann
7 years, 5 months ago (2013-07-09 12:16:25 UTC) #1
kustermann
I expect that we need to do status file updates after this CL since a ...
7 years, 5 months ago (2013-07-09 12:20:09 UTC) #2
Bill Hesse
lgtm
7 years, 5 months ago (2013-07-09 12:28:39 UTC) #3
kustermann
thank you
7 years, 5 months ago (2013-07-09 12:32:49 UTC) #4
kustermann
7 years, 5 months ago (2013-07-09 12:33:27 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 manually as r24840 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698