Issue 18826007: Reland r24563 and r24564 with fixes cumbersome API leading to leaks.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 18826007: Reland r24563 and r24564 with fixes cumbersome API leading to leaks. (Closed)

Created:
7 years, 5 months ago by Ivan Posva

Modified:
7 years, 5 months ago

Reviewers:
siva

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Reland r24563 and r24564 with fixes cumbersome API leading to leaks. - Add a WeakTable to the VM. This is used to remember the native peers registered through the Dart C API as well as assigning identity hashcodes to objects when needed. - Use the hashcode to lookup entries in the Expando. Committed: https://code.google.com/p/dart/source/detail?r=24822

Patch Set 1 #

Created: 7 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+362 lines, -197 lines)			Patch
M	runtime/lib/expando_patch.dart	View	1 chunk	+109 lines, -35 lines	0 comments	Download
M	runtime/lib/object.cc	View	2 chunks	+17 lines, -0 lines	0 comments	Download
M	runtime/lib/object_patch.dart	View	1 chunk	+14 lines, -8 lines	0 comments	Download
M	runtime/vm/bootstrap_natives.h	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	runtime/vm/gc_marker.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	runtime/vm/gc_marker.cc	View	2 chunks	+16 lines, -13 lines	0 comments	Download
M	runtime/vm/heap.h	View	4 chunks	+46 lines, -8 lines	0 comments	Download
M	runtime/vm/heap.cc	View	4 chunks	+32 lines, -13 lines	0 comments	Download
M	runtime/vm/pages.h	View	3 chunks	+0 lines, -14 lines	0 comments	Download
M	runtime/vm/pages.cc	View	1 chunk	+0 lines, -20 lines	0 comments	Download
M	runtime/vm/scavenger.h	View	4 chunks	+1 line, -12 lines	0 comments	Download
M	runtime/vm/scavenger.cc	View	4 chunks	+30 lines, -33 lines	0 comments	Download
M	runtime/vm/vm_sources.gypi	View	1 chunk	+2 lines, -0 lines	0 comments	Download
A +	runtime/vm/weak_table.h	View	7 chunks	+34 lines, -25 lines	0 comments	Download
A +	runtime/vm/weak_table.cc	View	3 chunks	+58 lines, -15 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Ivan Posva

7 years, 5 months ago (2013-07-08 21:41:17 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 manually as r24822 (presubmit successful).

Expand Messages | Collapse Messages