Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(266)

Issue 1880953004: Fix to respect `@optionalTypeArgs` (#196). (Closed)

Created:
4 years, 8 months ago by pquitslund
Modified:
4 years, 8 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/linter.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix to respect `@optionalTypeArgs` (#196). Updates `always_specify_types` to optionally require type parameters in cases where the type is flagged with `@optionalTypeArgs`. See: https://github.com/dart-lang/linter/issues/196 BUG= R=brianwilkerson@google.com Committed: https://github.com/dart-lang/linter/commit/64c0dfd92a908f2d13eb0c70840e5080e6396cfd

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+69 lines, -3 lines) Patch
M lib/src/rules/always_specify_types.dart View 4 chunks +45 lines, -3 lines 2 comments Download
M test/rules/always_specify_types.dart View 3 chunks +24 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
pquitslund
4 years, 8 months ago (2016-04-12 19:29:12 UTC) #2
Brian Wilkerson
lgtm https://codereview.chromium.org/1880953004/diff/1/lib/src/rules/always_specify_types.dart File lib/src/rules/always_specify_types.dart (right): https://codereview.chromium.org/1880953004/diff/1/lib/src/rules/always_specify_types.dart#newcode63 lib/src/rules/always_specify_types.dart:63: State s = new State(); // OK! "State" ...
4 years, 8 months ago (2016-04-12 19:35:24 UTC) #3
pquitslund
Committed patchset #1 (id:1) manually as 64c0dfd92a908f2d13eb0c70840e5080e6396cfd (presubmit successful).
4 years, 8 months ago (2016-04-12 19:51:04 UTC) #5
pquitslund
4 years, 8 months ago (2016-04-12 20:29:26 UTC) #6
Message was sent while issue was closed.
https://codereview.chromium.org/1880953004/diff/1/lib/src/rules/always_specif...
File lib/src/rules/always_specify_types.dart (right):

https://codereview.chromium.org/1880953004/diff/1/lib/src/rules/always_specif...
lib/src/rules/always_specify_types.dart:63: State s = new State(); // OK!
On 2016/04/12 19:35:24, Brian Wilkerson wrote:
> "State" --> "Key" (twice)?

Whoops!  Yeah, thanks!

Powered by Google App Engine
This is Rietveld 408576698