Issue 18808002: Report IMPLEMENTS_SUPER_CLASS

Issue 18808002: Report IMPLEMENTS_SUPER_CLASS (Closed)

Created:
7 years, 5 months ago by scheglov

Modified:
7 years, 5 months ago

Reviewers:
jwren, Brian Wilkerson

CC:
reviews_dartlang.org, lukeechurch_gmail.com

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Report IMPLEMENTS_SUPER_CLASS R=brianwilkerson@google.com, jwren@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=24804

Patch Set 2 : Test for implicit Object superclass #

Created: 7 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+59 lines, -1 line)			Patch
M	editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/error/CompileTimeErrorCode.java	View	1	1 chunk	+8 lines, -0 lines	0 comments	Download
M	editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/verifier/ErrorVerifier.java	View	1	2 chunks	+34 lines, -0 lines	0 comments	Download
M	editor/tools/plugins/com.google.dart.engine_test/src/com/google/dart/engine/resolver/CompileTimeErrorCodeTest.java	View	1	1 chunk	+17 lines, -0 lines	0 comments	Download
M	tests/language/language_analyzer.status	View	1	1 chunk	+0 lines, -1 line	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Brian Wilkerson

LGTM https://codereview.chromium.org/18808002/diff/1/editor/tools/plugins/com.google.dart.engine_test/src/com/google/dart/engine/resolver/CompileTimeErrorCodeTest.java File editor/tools/plugins/com.google.dart.engine_test/src/com/google/dart/engine/resolver/CompileTimeErrorCodeTest.java (right): https://codereview.chromium.org/18808002/diff/1/editor/tools/plugins/com.google.dart.engine_test/src/com/google/dart/engine/resolver/CompileTimeErrorCodeTest.java#newcode1497 editor/tools/plugins/com.google.dart.engine_test/src/com/google/dart/engine/resolver/CompileTimeErrorCodeTest.java:1497: public void test_implementsSuperClass() throws Exception { It might ...

7 years, 5 months ago (2013-07-08 13:31:27 UTC) #3

scheglov

https://codereview.chromium.org/18808002/diff/1/editor/tools/plugins/com.google.dart.engine_test/src/com/google/dart/engine/resolver/CompileTimeErrorCodeTest.java File editor/tools/plugins/com.google.dart.engine_test/src/com/google/dart/engine/resolver/CompileTimeErrorCodeTest.java (right): https://codereview.chromium.org/18808002/diff/1/editor/tools/plugins/com.google.dart.engine_test/src/com/google/dart/engine/resolver/CompileTimeErrorCodeTest.java#newcode1497 editor/tools/plugins/com.google.dart.engine_test/src/com/google/dart/engine/resolver/CompileTimeErrorCodeTest.java:1497: public void test_implementsSuperClass() throws Exception { On 2013/07/08 13:31:27, ...

7 years, 5 months ago (2013-07-08 16:36:09 UTC) #4

scheglov

7 years, 5 months ago (2013-07-08 16:36:49 UTC) #5

Message was sent while issue was closed.

Committed patchset #2 manually as r24804 (presubmit successful).

Expand Messages | Collapse Messages