Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(870)

Issue 18801005: Small cleanup in parser (Closed)

Created:
7 years, 5 months ago by hausner
Modified:
7 years, 5 months ago
Reviewers:
regis
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Small cleanup in parser When creating the type of the receiver variable 'this', use the token position of the class. R=regis@google.com Committed: https://code.google.com/p/dart/source/detail?r=24805

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -13 lines) Patch
M runtime/vm/parser.h View 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/parser.cc View 10 chunks +11 lines, -12 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
hausner
7 years, 5 months ago (2013-07-08 16:35:05 UTC) #1
regis
LGTM
7 years, 5 months ago (2013-07-08 16:42:50 UTC) #2
hausner
Committed patchset #1 manually as r24805 (presubmit successful).
7 years, 5 months ago (2013-07-08 16:48:55 UTC) #3
hausner
7 years, 5 months ago (2013-07-08 16:49:16 UTC) #4
Message was sent while issue was closed.
Thank you.

Powered by Google App Engine
This is Rietveld 408576698