Issue 1879823002: Don't track hidden tests in Engine.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1879823002: Don't track hidden tests in Engine. (Closed)

Created:
4 years, 8 months ago by nweiz

Modified:
4 years, 8 months ago

Reviewers:
kevmoo

CC:
reviews_dartlang.org

Base URL:
git@github.com:dart-lang/test@master

Target Ref:
refs/heads/master

Visibility:
Public.

Don't track hidden tests in Engine. We were closing hidden tests in Engine.close(), but this isn't necessary. A test is only hidden if it's complete, complete tests don't block closing their parent suites, *and* closing the parent suite will close the test anyway. R=kevmoo@google.com Committed: https://github.com/dart-lang/test/commit/f91eac1f307e597669921aef3108e310a463c484

Created: 4 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -16 lines)			Patch
	M	lib/src/runner/engine.dart	View		4 chunks	+4 lines, -16 lines	0 comments	Download

Total messages: 4 (1 generated)

nweiz

4 years, 8 months ago (2016-04-13 01:38:11 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
f91eac1f307e597669921aef3108e310a463c484 (presubmit successful).