Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(39)

Issue 187853004: Remove broken flags --all and --tests. (Closed)

Created:
6 years, 9 months ago by koda
Modified:
5 years, 7 months ago
Reviewers:
Ivan Posva
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Visibility:
Public.

Description

Remove broken flags --all and --tests. BUG=dart:17257 R=iposva@google.com Committed: https://code.google.com/p/dart/source/detail?r=33343

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -12 lines) Patch
M runtime/bin/run_vm_tests.cc View 5 chunks +3 lines, -12 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
koda
6 years, 9 months ago (2014-03-05 19:49:10 UTC) #1
Ivan Posva
LGTM -ip
6 years, 9 months ago (2014-03-05 20:52:41 UTC) #2
koda
Committed patchset #1 manually as r33343 (presubmit successful).
6 years, 9 months ago (2014-03-05 21:06:47 UTC) #3
regis
On 2014/03/05 21:06:47, koda wrote: > Committed patchset #1 manually as r33343 (presubmit successful). How ...
5 years, 7 months ago (2015-05-08 13:01:24 UTC) #4
koda
On 2015/05/08 13:01:24, regis wrote: > On 2014/03/05 21:06:47, koda wrote: > > Committed patchset ...
5 years, 7 months ago (2015-05-08 13:15:46 UTC) #5
regis
5 years, 7 months ago (2015-05-08 13:42:22 UTC) #6
Message was sent while issue was closed.
On 2015/05/08 13:15:46, koda wrote:
> On 2015/05/08 13:01:24, regis wrote:
> > On 2014/03/05 21:06:47, koda wrote:
> > > Committed patchset #1 manually as r33343 (presubmit successful).
> > 
> > How do you now run all vm tests?
> > (Previously run_vm_tests --all)
> > 
> > Thanks
> > Regis
> 
> tools/test.py vm/cc
> 
> ... which I believe runs "run_vm_tests --list" and then iterates over the
> output.

Perfect!
Thanks

Powered by Google App Engine
This is Rietveld 408576698