Dart2js testing: Add prefix files when running dart2js output on d8 or jsshell.

Dart2js testing: Add prefix files when running dart2js output on d8 or jsshell.

BUG=
R=ahe@google.com, kustermann@google.com

Committed: https://code.google.com/p/dart/source/detail?r=33369

[Bill Hesse, 2014-03-05 15:04:41]

https://codereview.chromium.org/187843002/diff/1/tools/testing/dart/compiler_...
File tools/testing/dart/compiler_configuration.dart (right):

https://codereview.chromium.org/187843002/diff/1/tools/testing/dart/compiler_...
tools/testing/dart/compiler_configuration.dart:185: var prefix = 'sdk/bin';
This was causing a double /.

[Bill Hesse, 2014-03-05 17:57:33]

PTAL.

[ahe, 2014-03-06 09:45:16]

lgtm

[kustermann, 2014-03-06 09:56:48]

https://codereview.chromium.org/187843002/diff/80001/tools/testing/dart/runti...
File tools/testing/dart/runtime_configuration.dart (right):

https://codereview.chromium.org/187843002/diff/80001/tools/testing/dart/runti...
tools/testing/dart/runtime_configuration.dart:80: List<String>
dart2jsPreambles(Uri preambleDir) => [];
It's strange that a RuntimeConfiguration knows about dart2js!

https://codereview.chromium.org/187843002/diff/80001/tools/testing/dart/runti...
tools/testing/dart/runtime_configuration.dart:152: List<String>
dart2jsPreambles(Uri preambleDir) {
This method name is not correct. It doesn't return a list of preambles, what it
does is it returns a list of commandline arguments (which include the preable
but miss the real file).

[kustermann, 2014-03-06 09:56:54]

lgtm

[ahe, 2014-03-06 10:21:08]

lgtm

https://codereview.chromium.org/187843002/diff/80001/tools/testing/dart/runti...
File tools/testing/dart/runtime_configuration.dart (right):

https://codereview.chromium.org/187843002/diff/80001/tools/testing/dart/runti...
tools/testing/dart/runtime_configuration.dart:80: List<String>
dart2jsPreambles(Uri preambleDir) => [];
On 2014/03/06 09:56:49, kustermann wrote:
> It's strange that a RuntimeConfiguration knows about dart2js!

Yes. It took Bill and I quite some time to find the best solution to this
problem:

* The exact preambles need depend on the runtime.

* The precise arguments (add -f or not) depend on the runtime.

* Whether or not you need preambles depend on the compiler.

https://codereview.chromium.org/187843002/diff/80001/tools/testing/dart/runti...
tools/testing/dart/runtime_configuration.dart:152: List<String>
dart2jsPreambles(Uri preambleDir) {
On 2014/03/06 09:56:49, kustermann wrote:
> This method name is not correct. It doesn't return a list of preambles, what
it
> does is it returns a list of commandline arguments (which include the preable
> but miss the real file).

dart2jsPreambleArguments?

[Bill Hesse, 2014-03-06 12:38:23]

Committed patchset #2 manually as r33369 (presubmit successful).