Issue 187763002: Mark compiler-internal fields of closure objects as final.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 187763002: Mark compiler-internal fields of closure objects as final. (Closed)

Created:
6 years, 9 months ago by Florian Schneider

Modified:
6 years, 9 months ago

Reviewers:
srdjan

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

Mark compiler-internal fields of closure objects as final. Those fields are written once at allocation time. Marking them as final improves code generation for closure allocation. R=srdjan@google.com Committed: https://code.google.com/p/dart/source/detail?r=33331

Created: 6 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -2 lines)			Patch
	M	runtime/vm/flow_graph_builder.cc	View		2 chunks	+2 lines, -2 lines	0 comments	Download

Total messages: 3 (0 generated)

Florian Schneider

6 years, 9 months ago (2014-03-05 15:46:45 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r33331 (presubmit successful).