Add 'uri' to HttpException, and include in toString.

Add 'uri' to HttpException, and include in toString.

BUG=
R=whesse@google.com

Committed: https://code.google.com/p/dart/source/detail?r=24786

[Anders Johnsen, 2013-07-05 12:25:22]

While this will be ', uri = /' in the simple cases, I think this is a good
start. We can look into adding more info to the Uri in the future, keeping an
eye on the extra cost.

[Bill Hesse, 2013-07-05 12:57:45]

lgtm

https://codereview.chromium.org/18768002/diff/1/sdk/lib/io/http.dart
File sdk/lib/io/http.dart (right):

https://codereview.chromium.org/18768002/diff/1/sdk/lib/io/http.dart#newcode1402
sdk/lib/io/http.dart:1402: 
Remove the blank line here?

https://codereview.chromium.org/18768002/diff/1/sdk/lib/io/http.dart#newcode1414
sdk/lib/io/http.dart:1414: return b.toString();
How about 
(uri == null) ? "HttpException: $message" :
                "HttpException: $message, uri = $uri"

https://codereview.chromium.org/18768002/diff/1/sdk/lib/io/http_impl.dart
File sdk/lib/io/http_impl.dart (right):

https://codereview.chromium.org/18768002/diff/1/sdk/lib/io/http_impl.dart#new...
sdk/lib/io/http_impl.dart:1289: });
If _currentUri is used to pass the URI to other methods, both synchronously and
asynchronously, then it should be set to null or INVALID when the connection is
done with this particular request.

If it is only used synchronously, then set it to null when we return.

[Anders Johnsen, 2013-07-05 13:08:51]

Committed patchset #2 manually as r24786 (presubmit successful).

[Anders Johnsen, 2013-08-20 05:46:31]

https://codereview.chromium.org/18768002/diff/1/sdk/lib/io/http.dart
File sdk/lib/io/http.dart (right):

https://codereview.chromium.org/18768002/diff/1/sdk/lib/io/http.dart#newcode1402
sdk/lib/io/http.dart:1402: 
On 2013/07/05 12:57:45, Bill Hesse wrote:
> Remove the blank line here?

Done.

https://codereview.chromium.org/18768002/diff/1/sdk/lib/io/http.dart#newcode1414
sdk/lib/io/http.dart:1414: return b.toString();
On 2013/07/05 12:57:45, Bill Hesse wrote:
> How about 
> (uri == null) ? "HttpException: $message" :
>                 "HttpException: $message, uri = $uri"

We use buffers in other exceptions, I think it's fine to follow that style.

https://codereview.chromium.org/18768002/diff/1/sdk/lib/io/http_impl.dart
File sdk/lib/io/http_impl.dart (right):

https://codereview.chromium.org/18768002/diff/1/sdk/lib/io/http_impl.dart#new...
sdk/lib/io/http_impl.dart:1289: });
On 2013/07/05 12:57:45, Bill Hesse wrote:
> If _currentUri is used to pass the URI to other methods, both synchronously
and
> asynchronously, then it should be set to null or INVALID when the connection
is
> done with this particular request.
> 
> If it is only used synchronously, then set it to null when we return.

Done.